add support for x-dart-test link tags in the new test package

add support for x-dart-test link tags in the new test package

Fixes https://github.com/dart-lang/web-components/issues/14

R=sigmund@google.com

Committed: https://github.com/dart-lang/web-components/commit/2ca25f00b5da345030c6f3d881fa91e4b5ec90c8

[jakemac, 2015-04-23 14:13:49]

jakemac@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-04-23 20:52:04]

lgtm!

https://codereview.chromium.org/1104453007/diff/40001/lib/build/test_compatib...
File lib/build/test_compatibility.dart (right):

https://codereview.chromium.org/1104453007/diff/40001/lib/build/test_compatib...
lib/build/test_compatibility.dart:5: /// Some transformers to maintain
compatibility with the new `test` package,
nit: Some transformers => Transformers

https://codereview.chromium.org/1104453007/diff/40001/lib/build/test_compatib...
lib/build/test_compatibility.dart:6: /// since it doesn't use normal dart script
tags in html.
minor nit: consider adding here a comment saying that you need 2 transformers:
 - a transformer to convert <lint rel="x-dart-test"> intro script tags so that
they can be processed by the rest of the web_component transformers
 - a second transformer to convert the output back, so that the `test` package
can find a <link rel="x-dart-test"> after all transformations are done.

That would clarify what you mean later on when you say "the first ..." or "the
last ..."

https://codereview.chromium.org/1104453007/diff/40001/lib/build/test_compatib...
lib/build/test_compatibility.dart:40: /// link[rel="x-dart-test"] tag.
minor nit:

a link[rel="x-dart-test"] tag

  =>

a `<link rel="x-dart-test">` tag

https://codereview.chromium.org/1104453007/diff/40001/lib/build/test_compatib...
lib/build/test_compatibility.dart:61: abstract class _BaseTestCompatTransformer
extends Transformer {
maybe rename to: _EntryPointOnlyTransformer?

(it's a bit tricky because `Test` is the noun here, but `test` makes me think
this is a testing class :-))

[jakemac, 2015-04-24 14:35:56]

https://codereview.chromium.org/1104453007/diff/40001/lib/build/test_compatib...
File lib/build/test_compatibility.dart (right):

https://codereview.chromium.org/1104453007/diff/40001/lib/build/test_compatib...
lib/build/test_compatibility.dart:5: /// Some transformers to maintain
compatibility with the new `test` package,
On 2015/04/23 20:52:04, Siggi Cherem (dart-lang) wrote:
> nit: Some transformers => Transformers

Done.

https://codereview.chromium.org/1104453007/diff/40001/lib/build/test_compatib...
lib/build/test_compatibility.dart:6: /// since it doesn't use normal dart script
tags in html.
On 2015/04/23 20:52:03, Siggi Cherem (dart-lang) wrote:
> minor nit: consider adding here a comment saying that you need 2 transformers:
>  - a transformer to convert <lint rel="x-dart-test"> intro script tags so that
> they can be processed by the rest of the web_component transformers
>  - a second transformer to convert the output back, so that the `test` package
> can find a <link rel="x-dart-test"> after all transformations are done.
> 
> That would clarify what you mean later on when you say "the first ..." or "the
> last ..."

Done.

https://codereview.chromium.org/1104453007/diff/40001/lib/build/test_compatib...
lib/build/test_compatibility.dart:40: /// link[rel="x-dart-test"] tag.
On 2015/04/23 20:52:03, Siggi Cherem (dart-lang) wrote:
> minor nit:
> 
> a link[rel="x-dart-test"] tag
> 
>   =>
> 
> a `<link rel="x-dart-test">` tag

Done.

https://codereview.chromium.org/1104453007/diff/40001/lib/build/test_compatib...
lib/build/test_compatibility.dart:61: abstract class _BaseTestCompatTransformer
extends Transformer {
On 2015/04/23 20:52:03, Siggi Cherem (dart-lang) wrote:
> maybe rename to: _EntryPointOnlyTransformer?
> 
> (it's a bit tricky because `Test` is the noun here, but `test` makes me think
> this is a testing class :-))

Done.

[jakemac, 2015-04-24 14:36:11]

Committed patchset #4 (id:60001) manually as
2ca25f00b5da345030c6f3d881fa91e4b5ec90c8 (presubmit successful).