Issue 11044021: Fixing up window.applicationCache and updating status files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11044021: Fixing up window.applicationCache and updating status files. (Closed)

Created:
8 years, 2 months ago by blois

Modified:
8 years, 2 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing up window.applicationCache and updating status files. BUG=4949 Committed: https://code.google.com/p/dart/source/detail?r=13204

Patch Set 1 #

Total comments: 3

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -4 lines)			Patch
M	lib/compiler/implementation/lib/native_helper.dart	View	2 chunks	+2 lines, -0 lines	2 comments	Download
M	samples/tests/samples/samples.status	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/html/html.status	View	2 chunks	+1 line, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://codereview.chromium.org/11044021/diff/1/lib/compiler/implementation/lib/native_helper.dart File lib/compiler/implementation/lib/native_helper.dart (right): https://codereview.chromium.org/11044021/diff/1/lib/compiler/implementation/lib/native_helper.dart#newcode54 lib/compiler/implementation/lib/native_helper.dart:54: if (name == 'ApplicationCache') return 'DOMApplicationCache'; We should ...

8 years, 2 months ago (2012-10-03 22:52:06 UTC) #2

blois

8 years, 2 months ago (2012-10-03 23:05:22 UTC) #3

https://codereview.chromium.org/11044021/diff/1/lib/compiler/implementation/l...
File lib/compiler/implementation/lib/native_helper.dart (right):

https://codereview.chromium.org/11044021/diff/1/lib/compiler/implementation/l...
lib/compiler/implementation/lib/native_helper.dart:54: if (name ==
'ApplicationCache') return 'DOMApplicationCache';
On 2012/10/03 22:52:06, vsm wrote:
> We should make ApplicationCache the real name.  In fact, anything that's
DOMFoo
> probably should be Foo.  Perhaps part of the grand rename sweep.

Yes, we have a number of those, would be good to do them all together.

Expand Messages | Collapse Messages