Issue 11043016: Set previous instruction pointers when building the graph.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11043016: Set previous instruction pointers when building the graph. (Closed)

Created:
8 years, 2 months ago by zerny-google

Modified:
8 years, 2 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Set previous instruction pointers when building the graph. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=13174

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -45 lines)			Patch
M	runtime/vm/flow_graph.cc	View		4 chunks	+5 lines, -24 lines	0 comments	Download
	runtime/vm/flow_graph_allocator.cc	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View		7 chunks	+7 lines, -7 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		3 chunks	+5 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

Kevin Millikin (Google)

LGTM if you change the one place in the register allocator that directly sets next/previous.

8 years, 2 months ago (2012-10-03 14:09:29 UTC) #2

zerny-google

8 years, 2 months ago (2012-10-03 14:25:49 UTC) #3

On 2012/10/03 14:09:29, kmillikin wrote:
> LGTM if you change the one place in the register allocator that directly sets
> next/previous.

Done.