Add the ability to get the Javascript console errors in Firefox in the test output when tests fail.

Add the ability to get the Javascript console errors in Firefox in the test output when tests fail.
Committed: https://code.google.com/p/dart/source/detail?r=13264

[gram, 2012-10-02 21:22:05]

For some reason, each time I gcl upload this change a new change is being
created in Rietveld, so I apologise for this not being a delta to the previous
change.

Also, sorry for the slow update; I spent two days writing a Chrome version that
I wanted to include in the revised change only to find that the necessary API
for getting the console logs only works in extensions to the developer tools
window, not the browser window. This was not documented in the Chrome extensions
API docs (I eventually found out from a StackOverflow post). So it is still just
Firefox unfortunately.

The main change here is that the extension is written by me, not a 3rd party.

[Emily Fortuna, 2012-10-02 22:40:49]

https://codereview.chromium.org/11043007/diff/1/tools/testing/extensions/fire...
File tools/testing/extensions/firefox/ConsoleCollector/chrome/content/console.js
(right):

https://codereview.chromium.org/11043007/diff/1/tools/testing/extensions/fire...
tools/testing/extensions/firefox/ConsoleCollector/chrome/content/console.js:3:
// BSD-style license that can be found in the LICENSE file.
I'm confused. This is for Chrome? Why is it in the extensions/firefox directory?
 Can you at least place a readme in this directory explaining how it's used (and
better, some comments in this file)

https://codereview.chromium.org/11043007/diff/1/tools/testing/extensions/fire...
tools/testing/extensions/firefox/ConsoleCollector/chrome/content/console.js:56:
.getService(Components.interfaces.nsIConsoleService);
80 char

https://codereview.chromium.org/11043007/diff/1/tools/testing/run_selenium.py
File tools/testing/run_selenium.py (right):

https://codereview.chromium.org/11043007/diff/1/tools/testing/run_selenium.py...
tools/testing/run_selenium.py:250: if browser_name == 'ff':
consider checking if browser is selenium.webdriver.Firefox instead of also
passing "browser_name"

[gram, 2012-10-03 17:31:30]

Emily, I have addressed your comments; I haven't done a new upload yet as I want
to figure out why a new CL is being created each time (possibly because I cloned
the SVN tree on my filesystem for this CL, so it wouldn't be NFS mounted and I
could run the webdriver installation script).

That said, I have found some other issue that I'm investigating. If you have any
knowledge about this let me know. What I find is that if I run test.py with
runtime=ff (this on Goobuntu), the browser does not exit after the test is done.
If I manually quit the browser the test results are reported correctly. Chrome
works fine; the bowser exits on its own. Are you aware of any issue with the
buildbots around this? This isn't caused by this CL, but it is affecting my
ability to test this CL properly so I want to get to the bottom of it.
 

On 2012/10/02 22:40:49, Emily Fortuna wrote:
>
https://codereview.chromium.org/11043007/diff/1/tools/testing/extensions/fire...
> File
tools/testing/extensions/firefox/ConsoleCollector/chrome/content/console.js
> (right):
> 
>
https://codereview.chromium.org/11043007/diff/1/tools/testing/extensions/fire...
> tools/testing/extensions/firefox/ConsoleCollector/chrome/content/console.js:3:
> // BSD-style license that can be found in the LICENSE file.
> I'm confused. This is for Chrome? Why is it in the extensions/firefox
directory?
>  Can you at least place a readme in this directory explaining how it's used
(and
> better, some comments in this file)
> 
>
https://codereview.chromium.org/11043007/diff/1/tools/testing/extensions/fire...
>
tools/testing/extensions/firefox/ConsoleCollector/chrome/content/console.js:56:
> .getService(Components.interfaces.nsIConsoleService);
> 80 char
> 
> https://codereview.chromium.org/11043007/diff/1/tools/testing/run_selenium.py
> File tools/testing/run_selenium.py (right):
> 
>
https://codereview.chromium.org/11043007/diff/1/tools/testing/run_selenium.py...
> tools/testing/run_selenium.py:250: if browser_name == 'ff':
> consider checking if browser is selenium.webdriver.Firefox instead of also
> passing "browser_name"

[gram, 2012-10-04 18:43:12]

PTAL

https://codereview.chromium.org/11043007/diff/1/tools/testing/extensions/fire...
File tools/testing/extensions/firefox/ConsoleCollector/chrome/content/console.js
(right):

https://codereview.chromium.org/11043007/diff/1/tools/testing/extensions/fire...
tools/testing/extensions/firefox/ConsoleCollector/chrome/content/console.js:3:
// BSD-style license that can be found in the LICENSE file.
On 2012/10/02 22:40:49, Emily Fortuna wrote:
> I'm confused. This is for Chrome? Why is it in the extensions/firefox
directory?
>  Can you at least place a readme in this directory explaining how it's used
(and
> better, some comments in this file)

No, this is "chrome" in the sense of UI; it is just the standard directory
layout for Firefox extensions.

https://codereview.chromium.org/11043007/diff/1/tools/testing/extensions/fire...
tools/testing/extensions/firefox/ConsoleCollector/chrome/content/console.js:56:
.getService(Components.interfaces.nsIConsoleService);
On 2012/10/02 22:40:49, Emily Fortuna wrote:
> 80 char

Dang - my Sublime Text is putting in tabs it seems!

https://codereview.chromium.org/11043007/diff/1/tools/testing/run_selenium.py
File tools/testing/run_selenium.py (right):

https://codereview.chromium.org/11043007/diff/1/tools/testing/run_selenium.py...
tools/testing/run_selenium.py:250: if browser_name == 'ff':
On 2012/10/02 22:40:49, Emily Fortuna wrote:
> consider checking if browser is selenium.webdriver.Firefox instead of also
> passing "browser_name"

I tried this; it didn't work, so I'm sticking to testing the name for now.

[Emily Fortuna, 2012-10-04 21:13:48]

lgtm with one suggestion

https://codereview.chromium.org/11043007/diff/12001/tools/testing/extensions/...
File tools/testing/extensions/firefox/ConsoleCollector/chrome/content/console.js
(right):

https://codereview.chromium.org/11043007/diff/12001/tools/testing/extensions/...
tools/testing/extensions/firefox/ConsoleCollector/chrome/content/console.js:4: 
Can you add an overall explanatory comment at the top of this file giving
context for how it's used?
Thanks!

https://codereview.chromium.org/11043007/diff/12001/tools/testing/extensions/...
tools/testing/extensions/firefox/ConsoleCollector/chrome/content/console.js:8:
// An arry for collecting the messages.
typo: array