Renamed Zone->StackZone, BaseZone->Zone, in preparation for changing isolate->get_zone() to return …

Renamed Zone->StackZone, BaseZone->Zone, in preparation for changing isolate->get_zone() to return what was called the BaseZone instead of its wrapper.  The GetBaseZone() methods were not renamed, to help the next CL.


BUG=

Committed: https://code.google.com/p/dart/source/detail?r=13314

[Tom Ball, 2012-10-05 17:31:59]

All configurations built and tested.

[siva, 2012-10-05 18:31:58]

lgtm

https://chromiumcodereview.appspot.com/11040062/diff/1/runtime/vm/dart_api_st...
File runtime/vm/dart_api_state.h (right):

https://chromiumcodereview.appspot.com/11040062/diff/1/runtime/vm/dart_api_st...
runtime/vm/dart_api_state.h:65: Zone* GetBaseZone() { return &zone_; }
Should we also rename the getter to GetZone() ?

https://chromiumcodereview.appspot.com/11040062/diff/1/runtime/vm/growable_ar...
File runtime/vm/growable_array.h (right):

https://chromiumcodereview.appspot.com/11040062/diff/1/runtime/vm/growable_ar...
runtime/vm/growable_array.h:91: Zone* zone_;  // Zone in which we are allocating
the array.
For this case we end up including a handles block which is not going to be used
at all. I haven't looked at what the overhead of that is, we may need to watch
this as GrowableArray is used a lot in the VM.

https://chromiumcodereview.appspot.com/11040062/diff/1/runtime/vm/native_entry.h
File runtime/vm/native_entry.h (right):

https://chromiumcodereview.appspot.com/11040062/diff/1/runtime/vm/native_entr...
runtime/vm/native_entry.h:35: void
NATIVE_ENTRY_FUNCTION(name)(Dart_NativeArguments args) {         \
Not related to your change but could you adjust the indentation of the '\' on
this line.

https://chromiumcodereview.appspot.com/11040062/diff/1/runtime/vm/zone.h
File runtime/vm/zone.h (right):

https://chromiumcodereview.appspot.com/11040062/diff/1/runtime/vm/zone.h#newc...
runtime/vm/zone.h:167: Zone* GetBaseZone() { return &zone_; }
ditto question about renaming this to GetZone

[Tom Ball, 2012-10-05 18:55:47]

http://codereview.chromium.org/11040062/diff/1/runtime/vm/dart_api_state.h
File runtime/vm/dart_api_state.h (right):

http://codereview.chromium.org/11040062/diff/1/runtime/vm/dart_api_state.h#ne...
runtime/vm/dart_api_state.h:65: Zone* GetBaseZone() { return &zone_; }
On 2012/10/05 18:31:58, siva wrote:
> Should we also rename the getter to GetZone() ?

Definitely.  I left it in there to make catching references to it easier for the
next CL (they're already gone in my local client :-).

http://codereview.chromium.org/11040062/diff/1/runtime/vm/growable_array.h
File runtime/vm/growable_array.h (right):

http://codereview.chromium.org/11040062/diff/1/runtime/vm/growable_array.h#ne...
runtime/vm/growable_array.h:91: Zone* zone_;  // Zone in which we are allocating
the array.
On 2012/10/05 18:31:58, siva wrote:
> For this case we end up including a handles block which is not going to be
used
> at all. I haven't looked at what the overhead of that is, we may need to watch
> this as GrowableArray is used a lot in the VM.

Okay, I'll keep an eye out for issues there.

http://codereview.chromium.org/11040062/diff/1/runtime/vm/native_entry.h
File runtime/vm/native_entry.h (right):

http://codereview.chromium.org/11040062/diff/1/runtime/vm/native_entry.h#newc...
runtime/vm/native_entry.h:35: void
NATIVE_ENTRY_FUNCTION(name)(Dart_NativeArguments args) {         \
On 2012/10/05 18:31:58, siva wrote:
> Not related to your change but could you adjust the indentation of the '\' on
> this line.

Done.

http://codereview.chromium.org/11040062/diff/1/runtime/vm/zone.h
File runtime/vm/zone.h (right):

http://codereview.chromium.org/11040062/diff/1/runtime/vm/zone.h#newcode167
runtime/vm/zone.h:167: Zone* GetBaseZone() { return &zone_; }
On 2012/10/05 18:31:58, siva wrote:
> ditto question about renaming this to GetZone
Done in next CL.