Add interface_name and implementation_name to IDLTypeInfo class and use them instead of dart_type.

Add interface_name and implementation_name to IDLTypeInfo class and use them instead of dart_type.


R=antonm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=13470

[Anton Muhin, 2012-10-05 15:15:30]

https://codereview.chromium.org/11040059/diff/1/lib/html/dart2js/html_dart2js...
File lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11040059/diff/1/lib/html/dart2js/html_dart2js...
lib/html/dart2js/html_dart2js.dart:23268: +abstract class RadioNodeList
implements NodeList {
I believe we're in process of killing NodeList, and if it's true, this
modification doesn't look correct.

https://codereview.chromium.org/11040059/diff/1/lib/html/scripts/generator.py
File lib/html/scripts/generator.py (right):

https://codereview.chromium.org/11040059/diff/1/lib/html/scripts/generator.py...
lib/html/scripts/generator.py:722: return
ImplementationClassName(self._dart_interface_name)
why not implementation_name here?

And overall, it's somewhat confusing to have both ImplementationClassName and
implementation_name

[podivilov, 2012-10-05 16:02:51]

https://codereview.chromium.org/11040059/diff/1/lib/html/dart2js/html_dart2js...
File lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11040059/diff/1/lib/html/dart2js/html_dart2js...
lib/html/dart2js/html_dart2js.dart:23268: +abstract class RadioNodeList
implements NodeList {
On 2012/10/05 15:15:31, Anton Muhin wrote:
> I believe we're in process of killing NodeList, and if it's true, this
> modification doesn't look correct.

We currently have NodeList interface, so RadioNodeList should implement it. If
we'll remove it in future, it would be trivial to fix this as well (it actually
will be fixed automatically).

https://codereview.chromium.org/11040059/diff/1/lib/html/scripts/generator.py
File lib/html/scripts/generator.py (right):

https://codereview.chromium.org/11040059/diff/1/lib/html/scripts/generator.py...
lib/html/scripts/generator.py:722: return
ImplementationClassName(self._dart_interface_name)
On 2012/10/05 15:15:31, Anton Muhin wrote:
> why not implementation_name here?
Done.
> 
> And overall, it's somewhat confusing to have both ImplementationClassName and
> implementation_name

ImplementationClassName is a static function that renders _FooImpl name. 

implementation_name is a virtual function that returns different stuff depending
on idl type.

[Anton Muhin, 2012-10-05 16:04:16]

https://codereview.chromium.org/11040059/diff/1/lib/html/scripts/generator.py
File lib/html/scripts/generator.py (right):

https://codereview.chromium.org/11040059/diff/1/lib/html/scripts/generator.py...
lib/html/scripts/generator.py:722: return
ImplementationClassName(self._dart_interface_name)
On 2012/10/05 16:02:51, podivilov wrote:
> On 2012/10/05 15:15:31, Anton Muhin wrote:
> > why not implementation_name here?
> Done.
> > 
> > And overall, it's somewhat confusing to have both ImplementationClassName
and
> > implementation_name
> 
> ImplementationClassName is a static function that renders _FooImpl name. 
> 
> implementation_name is a virtual function that returns different stuff
depending
> on idl type.

I do understand that, but presence of both is really confusing

[podivilov1, 2012-10-05 17:31:43]

PTAL

https://codereview.chromium.org/11040059/diff/1/lib/html/scripts/generator.py
File lib/html/scripts/generator.py (right):

https://codereview.chromium.org/11040059/diff/1/lib/html/scripts/generator.py...
lib/html/scripts/generator.py:722: return
ImplementationClassName(self._dart_interface_name)
Renamed

[Anton Muhin, 2012-10-05 17:37:03]

lgtm