Issue 11039020: Properly unparse sequences like x + +1 and x - -1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11039020: Properly unparse sequences like x + +1 and x - -1. (Closed)

Created:
8 years, 2 months ago by Anton Muhin

Modified:
8 years, 2 months ago

Reviewers:
Roman

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Properly unparse sequences like x + +1 and x - -1. R=smok@google.com BUG=5600 Committed: https://code.google.com/p/dart/source/detail?r=13119

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	lib/compiler/implementation/tree/unparser.dart	View		1 chunk	+7 lines, -2 lines	1 comment	Download
	M	tests/co19/co19-dart2dart.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Roman

8 years, 2 months ago (2012-10-02 13:22:24 UTC) #2

lgtm

https://codereview.chromium.org/11039020/diff/1/lib/compiler/implementation/t...
File lib/compiler/implementation/tree/unparser.dart (right):

https://codereview.chromium.org/11039020/diff/1/lib/compiler/implementation/t...
lib/compiler/implementation/tree/unparser.dart:292: if (beginToken !== null &&
beginToken.stringValue === opString) sb.add(' ');
80 chars

Expand Messages | Collapse Messages