Issue 11039018: Show noargs methods as () instead of (...) in find-as-you-type.

Issue 11039018: Show noargs methods as () instead of (...) in find-as-you-type. (Closed)

Created:
8 years, 2 months ago by Johnni Winther

Modified:
8 years, 2 months ago

Reviewers:
Lasse Reichstein Nielsen, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Show noargs methods as () instead of (...) in find-as-you-type. Committed: https://code.google.com/p/dart/source/detail?r=13165

Patch Set 2 : Updated cf. comments #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -8 lines)			Patch
M	pkg/dartdoc/lib/dartdoc.dart	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/dartdoc/lib/src/client/dropdown.dart	View	1	6 chunks	+9 lines, -6 lines	0 comments	Download
M	pkg/dartdoc/lib/src/client/search.dart	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	pkg/dartdoc/lib/src/dartdoc/nav.dart	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM, with terminology comments http://codereview.chromium.org/11039018/diff/1/pkg/dartdoc/lib/dartdoc.dart File pkg/dartdoc/lib/dartdoc.dart (right): http://codereview.chromium.org/11039018/diff/1/pkg/dartdoc/lib/dartdoc.dart#newcode641 pkg/dartdoc/lib/dartdoc.dart:641: memberInfo[NO_ARGS] = true; NO_ARGS -> ...

8 years, 2 months ago (2012-10-02 16:06:38 UTC) #2

Johnni Winther

8 years, 2 months ago (2012-10-03 09:22:16 UTC) #3

https://codereview.chromium.org/11039018/diff/1/pkg/dartdoc/lib/dartdoc.dart
File pkg/dartdoc/lib/dartdoc.dart (right):

https://codereview.chromium.org/11039018/diff/1/pkg/dartdoc/lib/dartdoc.dart#...
pkg/dartdoc/lib/dartdoc.dart:641: memberInfo[NO_ARGS] = true;
On 2012/10/02 16:06:38, ngeoffray wrote:
> NO_ARGS -> NO_PARAMS?

Done.

https://codereview.chromium.org/11039018/diff/1/pkg/dartdoc/lib/src/dartdoc/n...
File pkg/dartdoc/lib/src/dartdoc/nav.dart (right):

https://codereview.chromium.org/11039018/diff/1/pkg/dartdoc/lib/src/dartdoc/n...
pkg/dartdoc/lib/src/dartdoc/nav.dart:26: *        bool NO_ARGS, // Is true if
member is a no-args constructor/method.
On 2012/10/02 16:06:38, ngeoffray wrote:
> Why not just saying if the member doesn't take any parameter?

Done.

Expand Messages | Collapse Messages