Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 11037014: Mark pkg/intl/test/date_time_format_http_request_test as slow. (Closed)

Created:
8 years, 2 months ago by ricow1
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mark pkg/intl/test/date_time_format_http_request_test as slow. The additional nit capitalizations of markers has no semantic meaning, just for consistency. Committed: https://code.google.com/p/dart/source/detail?r=13101

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M pkg/pkg.status View 1 chunk +13 lines, -12 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
ricow1
8 years, 2 months ago (2012-10-02 06:25:03 UTC) #1
Mads Ager (google)
LGTM, at least that will help us figure out if this test is sometimes taking ...
8 years, 2 months ago (2012-10-02 06:32:23 UTC) #2
Alan Knight
8 years, 2 months ago (2012-10-02 16:38:18 UTC) #3
LGTM with one nit.

https://codereview.chromium.org/11037014/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/11037014/diff/1/pkg/pkg.status#newcode44
pkg/pkg.status:44: intl/test/date_time_format_http_request_test: Slow
Nit that putting this test here matches the condition, but doesn't agree with
the comment. It would be better to modify the comment to explain why it's there
or to put it under a separate condition with a different comment.

Powered by Google App Engine
This is Rietveld 408576698