Issue 11037010: Fix NPT when visiting qualifier in property access

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11037010: Fix NPT when visiting qualifier in property access (Closed)

Created:
8 years, 2 months ago by danrubel

Modified:
8 years, 2 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix NPT when visiting qualifier in property access Committed: https://code.google.com/p/dart/source/detail?r=13094

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java	View		1 chunk	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 2 months ago (2012-10-02 13:14:22 UTC) #3

https://codereview.chromium.org/11037010/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java
(right):

https://codereview.chromium.org/11037010/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java:677:
accept(x.getQualifier());
It might have been better for the invocation of 'accept' to go into the 'else'
clause below (without the surrounding 'if'). The qualifier should only be null
if it is part of a cascade section, and that would have made the semantics more
clear.

Expand Messages | Collapse Messages