Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1103643004: Add breadcrumb for the VM. (Closed)

Created:
5 years, 8 months ago by rmacnak
Modified:
5 years, 7 months ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -8 lines) Patch
M runtime/observatory/lib/src/elements/class_view.html View 1 1 chunk +1 line, -0 lines 4 comments Download
M runtime/observatory/lib/src/elements/code_view.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/context_view.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.html View 1 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.html View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/field_view.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_view.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_map.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_profile.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/library_view.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/metrics.html View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.html View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/object_view.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_view.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_view.html View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
rmacnak
5 years, 7 months ago (2015-04-29 18:39:45 UTC) #2
Cutch
https://codereview.chromium.org/1103643004/diff/20001/runtime/observatory/lib/src/elements/class_view.html File runtime/observatory/lib/src/elements/class_view.html (right): https://codereview.chromium.org/1103643004/diff/20001/runtime/observatory/lib/src/elements/class_view.html#newcode20 runtime/observatory/lib/src/elements/class_view.html:20: <vm-nav-menu vm="{{ cls.isolate.vm }}"></vm-nav-menu> what about app.vm? Might even ...
5 years, 7 months ago (2015-04-29 18:43:41 UTC) #3
turnidge
https://codereview.chromium.org/1103643004/diff/20001/runtime/observatory/lib/src/elements/class_view.html File runtime/observatory/lib/src/elements/class_view.html (right): https://codereview.chromium.org/1103643004/diff/20001/runtime/observatory/lib/src/elements/class_view.html#newcode20 runtime/observatory/lib/src/elements/class_view.html:20: <vm-nav-menu vm="{{ cls.isolate.vm }}"></vm-nav-menu> On 2015/04/29 18:43:41, Cutch wrote: ...
5 years, 7 months ago (2015-04-29 19:17:26 UTC) #4
rmacnak
https://codereview.chromium.org/1103643004/diff/20001/runtime/observatory/lib/src/elements/class_view.html File runtime/observatory/lib/src/elements/class_view.html (right): https://codereview.chromium.org/1103643004/diff/20001/runtime/observatory/lib/src/elements/class_view.html#newcode20 runtime/observatory/lib/src/elements/class_view.html:20: <vm-nav-menu vm="{{ cls.isolate.vm }}"></vm-nav-menu> On 2015/04/29 18:43:41, Cutch wrote: ...
5 years, 7 months ago (2015-04-29 19:37:20 UTC) #5
turnidge
LGTM https://codereview.chromium.org/1103643004/diff/20001/runtime/observatory/lib/src/elements/class_view.html File runtime/observatory/lib/src/elements/class_view.html (right): https://codereview.chromium.org/1103643004/diff/20001/runtime/observatory/lib/src/elements/class_view.html#newcode20 runtime/observatory/lib/src/elements/class_view.html:20: <vm-nav-menu vm="{{ cls.isolate.vm }}"></vm-nav-menu> On 2015/04/29 19:37:20, rmacnak ...
5 years, 7 months ago (2015-05-01 17:14:08 UTC) #6
rmacnak
5 years, 7 months ago (2015-05-01 18:23:46 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 45471 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698