Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Issue 1103643003: suggest async/await (Closed)

Created:
5 years, 8 months ago by danrubel
Modified:
5 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -121 lines) Patch
M pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart View 1 9 chunks +95 lines, -29 lines 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_contributor_test.dart View 10 chunks +226 lines, -92 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 8 months ago (2015-04-24 20:22:54 UTC) #2
scheglov
LGTM
5 years, 8 months ago (2015-04-24 20:31:18 UTC) #3
danrubel
5 years, 8 months ago (2015-04-24 21:40:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45415 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698