Issue 11036058: Show top-level members (again).

Issue 11036058: Show top-level members (again). (Closed)

Created:
8 years, 2 months ago by Johnni Winther

Modified:
8 years, 2 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Show top-level members (again). Use event.target to avoid capture of 's' in dartdoc search input. Committed: https://code.google.com/p/dart/source/detail?r=13294

Patch Set 2 : Updated cf. comment. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
	M	pkg/dartdoc/lib/dartdoc.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	pkg/dartdoc/lib/src/client/dropdown.dart	View	1	2 chunks	+2 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/11036058/diff/1/pkg/dartdoc/lib/src/client/dropdown.dart File pkg/dartdoc/lib/src/client/dropdown.dart (right): https://codereview.chromium.org/11036058/diff/1/pkg/dartdoc/lib/src/client/dropdown.dart#newcode331 pkg/dartdoc/lib/src/client/dropdown.dart:331: // Avoid preventing writing 's' in the search ...

8 years, 2 months ago (2012-10-05 14:06:21 UTC) #2

Johnni Winther

https://codereview.chromium.org/11036058/diff/1/pkg/dartdoc/lib/src/client/dropdown.dart File pkg/dartdoc/lib/src/client/dropdown.dart (right): https://codereview.chromium.org/11036058/diff/1/pkg/dartdoc/lib/src/client/dropdown.dart#newcode331 pkg/dartdoc/lib/src/client/dropdown.dart:331: // Avoid preventing writing 's' in the search input. ...

8 years, 2 months ago (2012-10-05 14:34:01 UTC) #3

Jennifer Messerly

8 years, 2 months ago (2012-10-05 18:12:39 UTC) #4

On 2012/10/05 14:34:01, Johnni Winther wrote:
>
https://codereview.chromium.org/11036058/diff/1/pkg/dartdoc/lib/src/client/dr...
> File pkg/dartdoc/lib/src/client/dropdown.dart (right):
> 
>
https://codereview.chromium.org/11036058/diff/1/pkg/dartdoc/lib/src/client/dr...
> pkg/dartdoc/lib/src/client/dropdown.dart:331: // Avoid preventing writing 's'
in
> the search input.
> On 2012/10/05 14:06:21, Lasse Reichstein Nielsen wrote:
> > Avoid preventing -> Allow (or "Don't prevent"). Two "ing"-words in a row
> sounds
> > weird.
> 
> Yes it does! Done.

lgtm too :)

Expand Messages | Collapse Messages