Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 11035057: Hide internal details of VM string implementation. (Closed)

Created:
8 years, 2 months ago by Mads Ager (google)
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Hide internal details of VM string implementation. R=lrn@google.com,srdjan@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=13352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -67 lines) Patch
M runtime/lib/string_base.dart View 11 chunks +26 lines, -26 lines 0 comments Download
M runtime/lib/string_patch.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier.h View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/symbols.h View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/corelib/string_base_vm_test.dart View 4 chunks +1 line, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
8 years, 2 months ago (2012-10-05 13:52:51 UTC) #1
Lasse Reichstein Nielsen
Excellent! LGTM and STV!
8 years, 2 months ago (2012-10-05 14:03:24 UTC) #2
srdjan
8 years, 2 months ago (2012-10-05 14:20:32 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698