Issue 11035032: Fixing SelectElement.selectedOptions to work on all platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11035032: Fixing SelectElement.selectedOptions to work on all platforms. (Closed)

Created:
8 years, 2 months ago by blois

Modified:
8 years, 2 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing SelectElement.selectedOptions to work on all platforms. This is a fixup of the original CL which broke dartium because I mistakenly applied the polyfill to both dart2js and dartium. Fix was to move impl_SelectElement.darttemplate to dart2js. BUG=4503 Committed: https://code.google.com/p/dart/source/detail?r=13304

Patch Set 1 #

Patch Set 2 : Moved selectelement.darttemplate. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -3 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View		3 chunks	+8 lines, -2 lines	0 comments	Download
M	lib/html/scripts/systemhtml.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	lib/html/templates/html/dart2js/impl_SelectElement.darttemplate	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
A	tests/html/selectelement_test.dart	View		1 chunk	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages