Issue 11035030: Refactor HttpClient internals to use Uri class for passing connection information

Issue 11035030: Refactor HttpClient internals to use Uri class for passing connection information (Closed)

Created:
8 years, 2 months ago by Søren Gjesse

Modified:
8 years, 2 months ago

Reviewers:
Anders Johnsen, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Refactor HttpClient internals to use Uri class for passing connection information This is in preparation for adding proxy server support. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=13232

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed review comments #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -23 lines)			Patch
	M	runtime/bin/http_impl.dart	View	1	4 chunks	+25 lines, -23 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM https://codereview.chromium.org/11035030/diff/1/runtime/bin/http_impl.dart File runtime/bin/http_impl.dart (right): https://codereview.chromium.org/11035030/diff/1/runtime/bin/http_impl.dart#newcode2047 runtime/bin/http_impl.dart:2047: request.headers.host = socketConn._host; Why not url.domain/url.port? https://codereview.chromium.org/11035030/diff/1/runtime/bin/http_impl.dart#newcode2161 runtime/bin/http_impl.dart:2161: ...

8 years, 2 months ago (2012-10-04 13:15:28 UTC) #2

Søren Gjesse

https://codereview.chromium.org/11035030/diff/1/runtime/bin/http_impl.dart File runtime/bin/http_impl.dart (right): https://codereview.chromium.org/11035030/diff/1/runtime/bin/http_impl.dart#newcode2047 runtime/bin/http_impl.dart:2047: request.headers.host = socketConn._host; On 2012/10/04 13:15:29, ajohnsen wrote: > ...

8 years, 2 months ago (2012-10-04 14:11:48 UTC) #3

floitsch

https://codereview.chromium.org/11035030/diff/4001/runtime/bin/http_impl.dart File runtime/bin/http_impl.dart (right): https://codereview.chromium.org/11035030/diff/4001/runtime/bin/http_impl.dart#newcode1971 runtime/bin/http_impl.dart:1971: if (method == null || uri.domain.isEmpty() == null) { ...

8 years, 2 months ago (2012-10-22 17:09:26 UTC) #4

Søren Gjesse

8 years, 2 months ago (2012-10-23 09:37:23 UTC) #5

https://codereview.chromium.org/11035030/diff/4001/runtime/bin/http_impl.dart
File runtime/bin/http_impl.dart (right):

https://codereview.chromium.org/11035030/diff/4001/runtime/bin/http_impl.dart...
runtime/bin/http_impl.dart:1971: if (method == null || uri.domain.isEmpty() ==
null) {
On 2012/10/22 17:09:26, floitsch wrote:
> should the "== null" go away?

Absolutely - good catch.

Expand Messages | Collapse Messages