Make event renames optional, not mandatory.

Make event renames optional, not mandatory.

That should lead to less frequent build breaks.

R=podivilov@chromium.org

Committed: https://code.google.com/p/dart/source/detail?r=13160

[podivilov, 2012-10-02 14:10:05]

Wouldn't new names sneak through and cause breakages later when we fix them?
Maybe just filter them and print a warning?

Given our new merging plans, will we benefit from deferring dom-to-html events
renaming?

[podivilov, 2012-10-02 15:26:54]

lgtm if comment addressed

http://codereview.chromium.org/11034022/diff/2002/lib/html/scripts/htmleventg...
File lib/html/scripts/htmleventgenerator.py (right):

http://codereview.chromium.org/11034022/diff/2002/lib/html/scripts/htmleventg...
lib/html/scripts/htmleventgenerator.py:237: for dom_name in
sorted(dom_event_names):
Doesn't it change the events order?

[Anton Muhin, 2012-10-02 15:31:46]

http://codereview.chromium.org/11034022/diff/2002/lib/html/scripts/htmleventg...
File lib/html/scripts/htmleventgenerator.py (right):

http://codereview.chromium.org/11034022/diff/2002/lib/html/scripts/htmleventg...
lib/html/scripts/htmleventgenerator.py:237: for dom_name in
sorted(dom_event_names):
It might a bit, but I am not sure it's principal: in case of onAb and onaB will
change positions, I am not sure it's a bad thing.

Uploaded updated libs.

On 2012/10/02 15:26:54, podivilov wrote:
> Doesn't it change the events order?

[podivilov, 2012-10-02 15:39:17]

http://codereview.chromium.org/11034022/diff/2002/lib/html/scripts/htmleventg...
File lib/html/scripts/htmleventgenerator.py (right):

http://codereview.chromium.org/11034022/diff/2002/lib/html/scripts/htmleventg...
lib/html/scripts/htmleventgenerator.py:237: for dom_name in
sorted(dom_event_names):
On 2012/10/02 15:31:46, Anton Muhin wrote:
> It might a bit, but I am not sure it's principal: in case of onAb and onaB
will
> change positions, I am not sure it's a bad thing.
> 
> Uploaded updated libs.
> 
> On 2012/10/02 15:26:54, podivilov wrote:
> > Doesn't it change the events order?
> 

Looks like ordering is broken now. I vote for not changing things here.

[Anton Muhin, 2012-10-02 15:39:57]

What do you mean by broken?

[podivilov, 2012-10-02 15:41:14]

On 2012/10/02 15:39:57, Anton Muhin wrote:
> What do you mean by broken?

E.g. fullscreenChange now goes after touchStart. Why are you changing this
anyway?

[Anton Muhin, 2012-10-02 15:43:12]

That doesn't mean  broken, that means changed.

Do we change semantics?  I don't think so.

I believe that all we wanted with sorted here was to have a stable order.

I am not sure that maintaing previous order is worth adding additional logic and
creating a new list.

On 2012/10/02 15:41:14, podivilov wrote:
> On 2012/10/02 15:39:57, Anton Muhin wrote:
> > What do you mean by broken?
> 
> E.g. fullscreenChange now goes after touchStart. Why are you changing this
> anyway?

[podivilov, 2012-10-02 15:50:19]

Having the fields alphabetically sorted is a nice property. What is the reason
for changing it? I don't think there is a substantial maintenance burden
associated with this logic.