Issue 11033049: Make fremontcut serial by default

Issue 11033049: Make fremontcut serial by default (Closed)

Created:
8 years, 2 months ago by vsm

Modified:
8 years, 2 months ago

Reviewers:
Anton Muhin, antonm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make fremontcut serial by default We suspect there are some race conditions in the Dartium build under heavy load. Making this serial by default until we have time to investigate. go.sh is still parallel by default as it's run by hand. Committed: https://code.google.com/p/dart/source/detail?r=13301

Patch Set 1 #

Patch Set 2 : Minor fix #

Total comments: 6

Patch Set 3 : Address comments #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -35 lines)			Patch
M	lib/html/scripts/dartdomgenerator.py	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	lib/html/scripts/databasebuilder.py	View		3 chunks	+40 lines, -28 lines	0 comments	Download
M	lib/html/scripts/fremontcutbuilder.py	View	1 2	5 chunks	+7 lines, -5 lines	0 comments	Download
M	lib/html/scripts/go.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm and thanks https://codereview.chromium.org/11033049/diff/2001/lib/html/scripts/fremontcutbuilder.py File lib/html/scripts/fremontcutbuilder.py (right): https://codereview.chromium.org/11033049/diff/2001/lib/html/scripts/fremontcutbuilder.py#newcode92 lib/html/scripts/fremontcutbuilder.py:92: def build_database(idl_files, database_dir, feature_defines = None, ...

8 years, 2 months ago (2012-10-05 15:55:42 UTC) #2

vsm

8 years, 2 months ago (2012-10-05 15:59:35 UTC) #3

Thanks, landing.

https://codereview.chromium.org/11033049/diff/2001/lib/html/scripts/fremontcu...
File lib/html/scripts/fremontcutbuilder.py (right):

https://codereview.chromium.org/11033049/diff/2001/lib/html/scripts/fremontcu...
lib/html/scripts/fremontcutbuilder.py:92: def build_database(idl_files,
database_dir, feature_defines = None,
Yes, I got confused by the existing code.  Fixed that and my changes.

On 2012/10/05 15:55:42, Anton Muhin wrote:
> isn't proper style for defaults is w/o spaces?  If yes, maybe just unify
> declaration before one you add

https://codereview.chromium.org/11033049/diff/2001/lib/html/scripts/fremontcu...
lib/html/scripts/fremontcutbuilder.py:149: def main(parallel = False):
On 2012/10/05 15:55:42, Anton Muhin wrote:
> ditto

Done.

https://codereview.chromium.org/11033049/diff/2001/lib/html/scripts/fremontcu...
lib/html/scripts/fremontcutbuilder.py:205: return build_database(idl_files,
database_dir, None, parallel)
On 2012/10/05 15:55:42, Anton Muhin wrote:
> nit: maybe use named form?

Done.

Expand Messages | Collapse Messages