Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 11033042: Change imports etc to new syntax. (Closed)

Created:
8 years, 2 months ago by gram
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change imports etc to new syntax. Fix issues wutrh handling console messages from DRT when using --list-tests and --list-groups. Committed: https://code.google.com/p/dart/source/detail?r=13327

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -42 lines) Patch
M utils/testrunner/http_server_test_runner.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M utils/testrunner/layout_test_controller.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M utils/testrunner/layout_test_runner.dart View 1 1 chunk +4 lines, -0 lines 1 comment Download
M utils/testrunner/options.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M utils/testrunner/pipeline_utils.dart View 1 2 chunks +3 lines, -0 lines 0 comments Download
M utils/testrunner/run_pipeline.dart View 1 8 chunks +29 lines, -29 lines 0 comments Download
M utils/testrunner/standard_test_runner.dart View 1 3 chunks +9 lines, -0 lines 2 comments Download
M utils/testrunner/testrunner.dart View 1 3 chunks +15 lines, -10 lines 1 comment Download
M utils/testrunner/utils.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gram
8 years, 2 months ago (2012-10-05 00:23:03 UTC) #1
Siggi Cherem (dart-lang)
lgtm, but if the part-of header works, let's do that too! https://codereview.chromium.org/11033042/diff/1/utils/testrunner/run_pipeline.dart File utils/testrunner/run_pipeline.dart (right): ...
8 years, 2 months ago (2012-10-05 00:39:52 UTC) #2
gram
PTAL. I found some bugs that had crept in to the list-tests and list-groups handling ...
8 years, 2 months ago (2012-10-05 21:27:40 UTC) #3
Siggi Cherem (dart-lang)
8 years, 2 months ago (2012-10-05 21:37:51 UTC) #4
lgtm, but not sure about the bug fix changes and what they do

https://codereview.chromium.org/11033042/diff/4002/utils/testrunner/layout_te...
File utils/testrunner/layout_test_runner.dart (right):

https://codereview.chromium.org/11033042/diff/4002/utils/testrunner/layout_te...
utils/testrunner/layout_test_runner.dart:8: // dart2js is not handling 'part of'
properly yet; when it does uncomment this.
nit: write as TODO(gram): ...

https://codereview.chromium.org/11033042/diff/4002/utils/testrunner/standard_...
File utils/testrunner/standard_test_runner.dart (right):

https://codereview.chromium.org/11033042/diff/4002/utils/testrunner/standard_...
utils/testrunner/standard_test_runner.dart:5: // dart2js is not handling 'part
of' properly yet; when it does uncomment this.
ditto

https://codereview.chromium.org/11033042/diff/4002/utils/testrunner/standard_...
utils/testrunner/standard_test_runner.dart:166: if (notifyDone != null) {
I don't see what's the relation of this part of the change with the import
changes?

https://codereview.chromium.org/11033042/diff/4002/utils/testrunner/testrunne...
File utils/testrunner/testrunner.dart (right):

https://codereview.chromium.org/11033042/diff/4002/utils/testrunner/testrunne...
utils/testrunner/testrunner.dart:195: out.writeString(msg.substring(idx+3));
style nit: please add spaces around +

Powered by Google App Engine
This is Rietveld 408576698