Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 11033024: Get rid of webkit renames. (Closed)

Created:
8 years, 2 months ago by podivilov
Modified:
8 years, 2 months ago
Reviewers:
vsm, Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -42 lines) Patch
M lib/html/dart2js/html_dart2js.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 3 chunks +10 lines, -10 lines 0 comments Download
M lib/html/idl/dart/dart.idl View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/scripts/databasebuilder.py View 1 2 5 chunks +5 lines, -12 lines 0 comments Download
M lib/html/scripts/fremontcutbuilder.py View 1 chunk +1 line, -12 lines 0 comments Download
M lib/html/scripts/generator.py View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/scripts/htmlrenamer.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
podivilov
8 years, 2 months ago (2012-10-04 13:39:15 UTC) #1
vsm
https://codereview.chromium.org/11033024/diff/1/lib/html/dartium/html_dartium.dart File lib/html/dartium/html_dartium.dart (right): https://codereview.chromium.org/11033024/diff/1/lib/html/dartium/html_dartium.dart#newcode9581 lib/html/dartium/html_dartium.dart:9581: +/// @domName DOMCoreException DBC - note, DOMException is the ...
8 years, 2 months ago (2012-10-04 14:28:11 UTC) #2
Anton Muhin
https://codereview.chromium.org/11033024/diff/1/lib/html/scripts/databasebuilder.py File lib/html/scripts/databasebuilder.py (right): https://codereview.chromium.org/11033024/diff/1/lib/html/scripts/databasebuilder.py#newcode118 lib/html/scripts/databasebuilder.py:118: rename = lambda name: name.split('::')[-1] I don't think it's ...
8 years, 2 months ago (2012-10-04 14:39:22 UTC) #3
podivilov
http://codereview.chromium.org/11033024/diff/1/lib/html/dartium/html_dartium.dart File lib/html/dartium/html_dartium.dart (right): http://codereview.chromium.org/11033024/diff/1/lib/html/dartium/html_dartium.dart#newcode9581 lib/html/dartium/html_dartium.dart:9581: +/// @domName DOMCoreException On 2012/10/04 14:28:11, vsm wrote: > ...
8 years, 2 months ago (2012-10-04 16:15:46 UTC) #4
Anton Muhin
lgtm http://codereview.chromium.org/11033024/diff/5002/lib/html/scripts/databasebuilder.py File lib/html/scripts/databasebuilder.py (right): http://codereview.chromium.org/11033024/diff/5002/lib/html/scripts/databasebuilder.py#newcode118 lib/html/scripts/databasebuilder.py:118: strip_module = lambda name: name.split('::')[-1] not: strip_module[s]?
8 years, 2 months ago (2012-10-04 16:36:27 UTC) #5
podivilov
http://codereview.chromium.org/11033024/diff/5002/lib/html/scripts/databasebuilder.py File lib/html/scripts/databasebuilder.py (right): http://codereview.chromium.org/11033024/diff/5002/lib/html/scripts/databasebuilder.py#newcode118 lib/html/scripts/databasebuilder.py:118: strip_module = lambda name: name.split('::')[-1] On 2012/10/04 16:36:28, Anton ...
8 years, 2 months ago (2012-10-04 17:30:20 UTC) #6
Anton Muhin
8 years, 2 months ago (2012-10-04 17:30:47 UTC) #7
still lgtm

Powered by Google App Engine
This is Rietveld 408576698