Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 11032035: Move Bidi functions into methods to make the docs look better (Closed)

Created:
8 years, 2 months ago by Alan Knight
Modified:
8 years, 2 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move Bidi functions into methods to make the docs look better Committed: https://code.google.com/p/dart/source/detail?r=13261

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+471 lines, -447 lines) Patch
M pkg/intl/lib/bidi_formatter.dart View 1 3 chunks +8 lines, -6 lines 0 comments Download
M pkg/intl/lib/bidi_utils.dart View 1 3 chunks +317 lines, -309 lines 0 comments Download
M pkg/intl/lib/intl.dart View 1 2 3 chunks +11 lines, -22 lines 0 comments Download
M pkg/intl/lib/message_lookup_local.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/intl/lib/src/intl_helpers.dart View 1 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/intl/test/bidi_format_test.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/intl/test/bidi_utils_test.dart View 1 3 chunks +110 lines, -110 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alan Knight
This moves the Bidi standalone functions and fields into statics on a Bidi class. The ...
8 years, 2 months ago (2012-10-04 17:38:45 UTC) #1
Emily Fortuna
https://codereview.chromium.org/11032035/diff/1/pkg/intl/lib/bidi_utils.dart File pkg/intl/lib/bidi_utils.dart (right): https://codereview.chromium.org/11032035/diff/1/pkg/intl/lib/bidi_utils.dart#newcode53 pkg/intl/lib/bidi_utils.dart:53: * text. ####### is this a marker for more ...
8 years, 2 months ago (2012-10-04 18:37:54 UTC) #2
Alan Knight
https://codereview.chromium.org/11032035/diff/1/pkg/intl/lib/bidi_utils.dart File pkg/intl/lib/bidi_utils.dart (right): https://codereview.chromium.org/11032035/diff/1/pkg/intl/lib/bidi_utils.dart#newcode53 pkg/intl/lib/bidi_utils.dart:53: * text. ####### On 2012/10/04 18:37:55, Emily Fortuna wrote: ...
8 years, 2 months ago (2012-10-04 19:34:22 UTC) #3
Emily Fortuna
8 years, 2 months ago (2012-10-04 21:11:47 UTC) #4
lgtm!

Powered by Google App Engine
This is Rietveld 408576698