Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11032025: Temporarily disable finding browser on safari while debugging (Closed)

Created:
8 years, 2 months ago by Alan Knight
Modified:
8 years, 2 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Temporarily disable finding browser on safari while debugging Committed: https://code.google.com/p/dart/source/detail?r=13131

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M pkg/pkg.status View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alan Knight
8 years, 2 months ago (2012-10-02 17:50:44 UTC) #1
Emily Fortuna
lgtm with adjustment https://codereview.chromium.org/11032025/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/11032025/diff/1/pkg/pkg.status#newcode59 pkg/pkg.status:59: intl/test/find_default_locale_browser_test add ": Fail" to this ...
8 years, 2 months ago (2012-10-02 18:11:39 UTC) #2
Alan Knight
8 years, 2 months ago (2012-10-02 19:34:13 UTC) #3 
https://codereview.chromium.org/11032025/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/11032025/diff/1/pkg/pkg.status#newcode59
pkg/pkg.status:59: intl/test/find_default_locale_browser_test
On 2012/10/02 18:11:39, Emily Fortuna wrote:
> add ": Fail" to this line

Oops. Done.

Powered by Google App Engine
This is Rietveld 408576698