Issue 11032003: Add integer negate back to list of intrinsified methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11032003: Add integer negate back to list of intrinsified methods. (Closed)

Created:
8 years, 2 months ago by srdjan

Modified:
8 years, 2 months ago

Reviewers:
Mads Ager (google), hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add integer negate back to list of intrinsified methods. Committed: https://code.google.com/p/dart/source/detail?r=13075

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -0 lines)			Patch
M	runtime/vm/intrinsifier.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM, thanks Srdjan. Sorry for removing this. I should have asked in the code review ...

8 years, 2 months ago (2012-10-01 16:50:20 UTC) #3

Mads Ager (google)

8 years, 2 months ago (2012-10-01 17:01:26 UTC) #4

On 2012/10/01 16:50:20, Mads Ager wrote:
> LGTM, thanks Srdjan. Sorry for removing this. I should have asked in the code
> review instead of assuming that it wasn't there because I couldn't find it.

Srdjan, I just ran all the tests with an UNREACHABLE in the generation method
for negate in intrinsifier_ia32.cc without hitting it. Also, I ran the following
test:

f(x) => -x;

main() {
  for (var i = 0; i < 100000; i++) f(43);
}

without hitting it. Where is negate used?

Expand Messages | Collapse Messages