Issue 11031040: Don't inline functions above the deoptimization threshold.

Issue 11031040: Don't inline functions above the deoptimization threshold. (Closed)

Created:
8 years, 2 months ago by zerny-google

Modified:
8 years, 2 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't inline functions above the deoptimization threshold. Moved deoptimization counter increment code into the PcMarker instruction where it executes on each occurring function in the optimized frame. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=13223

Patch Set 1 #

Patch Set 2 : Typo and added deopt increment #

Total comments: 4

Patch Set 3 : Review comments. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -13 lines)			Patch
M	runtime/vm/code_generator.cc	View	1 2	2 chunks	+4 lines, -10 lines	0 comments	Download
M	runtime/vm/deopt_instructions.cc	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	1	2 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zerny-google

On 2012/10/04 10:41:58, zerny wrote: Fixed a typo and added deopt increment code to each ...

8 years, 2 months ago (2012-10-04 11:28:01 UTC) #2

Kevin Millikin (Google)

lgtm https://codereview.chromium.org/11031040/diff/1002/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://codereview.chromium.org/11031040/diff/1002/runtime/vm/code_generator.cc#newcode1588 runtime/vm/code_generator.cc:1588: Function::Handle(optimized_code.function()).ToFullyQualifiedCString(), Not a bit deal, but we don't ...

8 years, 2 months ago (2012-10-04 11:37:59 UTC) #3

zerny-google

8 years, 2 months ago (2012-10-04 12:18:41 UTC) #4

https://codereview.chromium.org/11031040/diff/1002/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/11031040/diff/1002/runtime/vm/code_generator....
runtime/vm/code_generator.cc:1588:
Function::Handle(optimized_code.function()).ToFullyQualifiedCString(),
On 2012/10/04 11:37:59, kmillikin wrote:
> Not a bit deal, but we don't need two handles here.

Done.

https://codereview.chromium.org/11031040/diff/1002/runtime/vm/deopt_instructi...
File runtime/vm/deopt_instructions.cc (right):

https://codereview.chromium.org/11031040/diff/1002/runtime/vm/deopt_instructi...
runtime/vm/deopt_instructions.cc:427: // Clear invocation counter so that the
function gets optimized only after
On 2012/10/04 11:37:59, kmillikin wrote:
> Comment should say 'reoptimized'.  Maybe we should say 'hopefully' in there
> somewhere :)

Done. :)

Expand Messages | Collapse Messages