Extract archives by writing .tar.gz to temp file on Windows.

Extract archives by writing .tar.gz to temp file on Windows.

Committed: https://code.google.com/p/dart/source/detail?r=13096

[Bob Nystrom, 2012-10-02 00:51:30]

This patch is nasty. Even with this, I still get some (say 1 in 5) intermittent
failures when I run the hosted tests locally. I'd like to check this in and then
enable the hosted tests on the bots and see how they fare. If it's flaky on them
too, I'll back this out.

[nweiz, 2012-10-02 01:04:13]

lgtm

https://chromiumcodereview.appspot.com/11031015/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://chromiumcodereview.appspot.com/11031015/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:159: outputStream.onError = completer.completeException;
It's possible that both streams could throw errors. It might be better to ensure
that only the first one invokes the completer.

https://chromiumcodereview.appspot.com/11031015/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:669: // TODO(rnystrom): Setting the working directory instead
of passing in
I don't know if this is really a TODO, since you can't do anything about it.

https://chromiumcodereview.appspot.com/11031015/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:712: /*
I don't like checking in commented-out code. I feel like source control is
supposed to handle keeping track of dead code.

[Bob Nystrom, 2012-10-02 01:36:37]

Thanks!

https://chromiumcodereview.appspot.com/11031015/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://chromiumcodereview.appspot.com/11031015/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:159: outputStream.onError = completer.completeException;
On 2012/10/02 01:04:13, nweiz wrote:
> It's possible that both streams could throw errors. It might be better to
ensure
> that only the first one invokes the completer.

Done.

https://chromiumcodereview.appspot.com/11031015/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:669: // TODO(rnystrom): Setting the working directory instead
of passing in
On 2012/10/02 01:04:13, nweiz wrote:
> I don't know if this is really a TODO, since you can't do anything about it.

Done.

https://chromiumcodereview.appspot.com/11031015/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:712: /*
On 2012/10/02 01:04:13, nweiz wrote:
> I don't like checking in commented-out code. I feel like source control is
> supposed to handle keeping track of dead code.

Done.