Issue 11030012: Add constructor for CustomEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11030012: Add constructor for CustomEvent. (Closed)

Created:
8 years, 2 months ago by Emily Fortuna

Modified:
8 years, 2 months ago

Reviewers:
vsm, blois

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add constructor for CustomEvent. Committed: https://code.google.com/p/dart/source/detail?r=13127

Patch Set 1 : #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -10 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View	3 chunks	+17 lines, -3 lines	0 comments	Download
	lib/html/dartium/html_dartium.dart	View	4 chunks	+17 lines, -3 lines	0 comments	Download
	lib/html/scripts/htmlrenamer.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
	lib/html/src/shared_FactoryProviders.dart	View	1 chunk	+9 lines, -0 lines	1 comment	Download
	lib/html/templates/html/interface/interface_CustomEvent.darttemplate	View	1 chunk	+14 lines, -0 lines	0 comments	Download
	tests/html/event_customevent_test.dart	View	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

8 years, 2 months ago (2012-10-02 17:14:06 UTC) #3

lgtm

https://codereview.chromium.org/11030012/diff/4001/lib/html/src/shared_Factor...
File lib/html/src/shared_FactoryProviders.dart (right):

https://codereview.chromium.org/11030012/diff/4001/lib/html/src/shared_Factor...
lib/html/src/shared_FactoryProviders.dart:6: static CustomEvent
createCustomEvent(String type, [bool canBubble = true,
Nit- there isn't really any reason to have default properties here since the
defaults are being specified by the constructor and it's just passing through.

Expand Messages | Collapse Messages