Issue 11029048: Update buildbot.py to support jsshell builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11029048: Update buildbot.py to support jsshell builders. (Closed)

Created:
8 years, 2 months ago by ricow1

Modified:
8 years, 2 months ago

Reviewers:
ahe, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Update buildbot.py to support jsshell builders. Committed: https://code.google.com/p/dart/source/detail?r=13342

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -9 lines)			Patch
	M	utils/compiler/buildbot.py	View		3 chunks	+11 lines, -9 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ricow1

https://codereview.chromium.org/11029048/diff/1/utils/compiler/buildbot.py File utils/compiler/buildbot.py (right): https://codereview.chromium.org/11029048/diff/1/utils/compiler/buildbot.py#newcode118 utils/compiler/buildbot.py:118: if dart2js_pattern.group(3) == 'jsshell': I can change this, but ...

8 years, 2 months ago (2012-10-05 12:29:36 UTC) #1

LGTM

Expand Messages | Collapse Messages