Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 11028068: Replacing non-portable CanvasRenderingContext.setFillColor with more portable variants. (Closed)

Created:
8 years, 2 months ago by blois
Modified:
8 years, 2 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Replacing non-portable CanvasRenderingContext.setFillColor with more portable variants. This is the same as the earlier CL for this, which failed because of dartium build issues which have since been fixed by Anton. BUG=4592 Committed: https://code.google.com/p/dart/source/detail?r=13361

Patch Set 1 #

Patch Set 2 : Integrating latest build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -134 lines) Patch
M lib/html/dart2js/html_dart2js.dart View 6 chunks +49 lines, -10 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 6 chunks +45 lines, -88 lines 0 comments Download
M lib/html/scripts/htmlrenamer.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
A lib/html/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate View 1 chunk +23 lines, -0 lines 0 comments Download
A lib/html/templates/html/interface/interface_CanvasRenderingContext2D.darttemplate View 1 chunk +38 lines, -0 lines 0 comments Download
M tests/html/canvas_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
M tests/html/canvas_using_html_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
A tests/html/canvasrenderingcontext2d_test.dart View 1 chunk +84 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
blois
8 years, 2 months ago (2012-10-05 19:55:02 UTC) #1
vsm
8 years, 2 months ago (2012-10-05 22:27:32 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698