Fixed the issue with the ConsoleCollector extension causing FF to hang if run from WebDriver.

Fixed the issue with the ConsoleCollector extension causing FF to hang if run from WebDriver.
Committed: https://code.google.com/p/dart/source/detail?r=13318

[gram, 2012-10-05 18:14:37]

run_selenium is the same as before; the primary change is that the event handler
on the window only gets hooked in when the browser is fully loaded; it was being
called too early before. I also added some cleanup code but that should not
affect things and will probably never be used in our tests.

[Emily Fortuna, 2012-10-05 18:41:41]

one fix first please

https://codereview.chromium.org/11028067/diff/1/tools/testing/run_selenium.py
File tools/testing/run_selenium.py (right):

https://codereview.chromium.org/11028067/diff/1/tools/testing/run_selenium.py...
tools/testing/run_selenium.py:250: if browser_name == 'ff':
if type(browser) is selenium.webdriver.firefox.webdriver.WebDriver:
should work

[gram, 2012-10-05 19:59:08]

PTAL

https://codereview.chromium.org/11028067/diff/1/tools/testing/run_selenium.py
File tools/testing/run_selenium.py (right):

https://codereview.chromium.org/11028067/diff/1/tools/testing/run_selenium.py...
tools/testing/run_selenium.py:250: if browser_name == 'ff':
On 2012/10/05 18:41:41, Emily Fortuna wrote:
> if type(browser) is selenium.webdriver.firefox.webdriver.WebDriver:
> should work

Done.

[Emily Fortuna, 2012-10-05 20:26:58]

lgtm