- Add support to interrupt a running isolate

- Add support to interrupt a running isolate with the following command:
<===  InterruptCmd = "{" RequestId "," command ":" interrupt "," params ":" "{" isolateId ":" Integer "}" "}"
===>  InterruptCmdResp = "{" RequestId "}"

- Send isolate events over to the debugger client in the following format:
===>  "{" event ":" isolate "," params ":" "{" reason ":" created "," id ":" Integer "}" "}"
===>  "{" event ":" isolate "," params ":" "{" reason ":" shutdown "," id ":" Integer "}" "}"
===>  "{" event ":" paused "," params ":" "{" reason ":" interrupted "," callFrames ":" StackTrace "}" "}"

- Added id ";" Integer, to params in all paused events messages

- create per isolate debugger message queues, instead of the global static one

- Add 'i' command in ddbg to exercise the interrupt feature

- Add support for handling isolave event messages in ddbg
Committed: https://code.google.com/p/dart/source/detail?r=13333

[devoncarew, 2012-10-05 18:05:36]

I have a few nomenclature suggestions:

What about naming the command "interruptIsolate" instead of "interrupt"?

> - Added id ";" Integer, to params in all paused events messages

What about calling this isolateId?

> "{" event ":" isolate "," params ":" "{" reason ":" created "," id ":" Integer
"}" "}"
> "{" event ":" isolate "," params ":" "{" reason ":" shutdown "," id ":"
Integer "}" "}"

Perhaps create two separate event types, "isolateCreated" and "isolateShutdown",
instead of one event w/ a reason field?

[hausner, 2012-10-05 18:06:34]

LGTM with comments. Please also update the Dart Debugger Wire Protocol document
I shared with you. I try to keep the document and implementation in sync. It's
the spec that the Editor team uses to implement their side of the protocol
implementation.

https://chromiumcodereview.appspot.com/11028040/diff/8014/runtime/bin/dbg_mes...
File runtime/bin/dbg_message.cc (right):

https://chromiumcodereview.appspot.com/11028040/diff/8014/runtime/bin/dbg_mes...
runtime/bin/dbg_message.cc:800: const char* start,
Indentation

https://chromiumcodereview.appspot.com/11028040/diff/8014/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://chromiumcodereview.appspot.com/11028040/diff/8014/runtime/vm/debugger...
runtime/vm/debugger.cc:1355: Isolate* isolate = Isolate::Current();
Why do you need to get the debugger object through the current isolate? We are
in an instance method, and *this should be the same as
Isolate::Current()->debugger().

I see that you made SignalIsolateEvent() a static method, but SignalBpReached is
an instance method.

https://chromiumcodereview.appspot.com/11028040/diff/8014/tools/ddbg.dart
File tools/ddbg.dart (right):

https://chromiumcodereview.appspot.com/11028040/diff/8014/tools/ddbg.dart#new...
tools/ddbg.dart:51: i <id> Interrupt execution of given isolate id
Don't you also want/need a command to list isolates?

[siva, 2012-10-05 22:35:06]

Updated the document.

Regarding using interruptIsolate instead of interrupt I would
prefer to keep the messages small if possible.

We want to club events into categories and hence the isolate
event (with created/shutdown maybe more later) instead of
new IsolateCreated and IsolateShutdown event types. That is
also why interrupt is clubbed into "paused" event.

https://chromiumcodereview.appspot.com/11028040/diff/8014/runtime/bin/dbg_mes...
File runtime/bin/dbg_message.cc (right):

https://chromiumcodereview.appspot.com/11028040/diff/8014/runtime/bin/dbg_mes...
runtime/bin/dbg_message.cc:800: const char* start,
On 2012/10/05 18:06:34, hausner wrote:
> Indentation

Done.

https://chromiumcodereview.appspot.com/11028040/diff/8014/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://chromiumcodereview.appspot.com/11028040/diff/8014/runtime/vm/debugger...
runtime/vm/debugger.cc:1355: Isolate* isolate = Isolate::Current();
Good point, this is not a static function so just GetIsolateId() is sufficient.

On 2012/10/05 18:06:34, hausner wrote:
> Why do you need to get the debugger object through the current isolate? We are
> in an instance method, and *this should be the same as
> Isolate::Current()->debugger().
> 
> I see that you made SignalIsolateEvent() a static method, but SignalBpReached
is
> an instance method.

https://chromiumcodereview.appspot.com/11028040/diff/8014/tools/ddbg.dart
File tools/ddbg.dart (right):

https://chromiumcodereview.appspot.com/11028040/diff/8014/tools/ddbg.dart#new...
tools/ddbg.dart:51: i <id> Interrupt execution of given isolate id
Yes, but I haven't added that yet. That is the next
one. Currently I am looking at the event messages being printed and use that to
figure out the isolate ID to use.

On 2012/10/05 18:06:34, hausner wrote:
> Don't you also want/need a command to list isolates?