Add firefox jsshell support in testing scripts.

Add firefox jsshell support in testing scripts.

Additionally, introduce a new jscl key in the configuration for less verbose status file section headers (i.e., $jscl instead of ($runtime == d8 || $runtime == jsshell)

This also adds support for setting environment variables in a command.
Committed: https://code.google.com/p/dart/source/detail?r=13230

[ricow1, 2012-10-04 10:39:13]

https://codereview.chromium.org/11028023/diff/1/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11028023/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:483: } else if (configuration['runtime'] ==
'jsshell') {
we could combine the d8 case and this case by letting utility functions find out
which executable and environment depending on configuration, but I actually
think this is more readable being explicit here.

[ricow1, 2012-10-04 10:40:56]

note that I have not updated status files to reflect this new option. I want us
to agree on the structure of this first.

[Mads Ager (google), 2012-10-04 11:33:35]

I think the overall structure is as it should be.

https://codereview.chromium.org/11028023/diff/2001/tools/testing/dart/test_op...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/11028023/diff/2001/tools/testing/dart/test_op...
tools/testing/dart/test_options.dart:479: configuration['browser'] = true;
Can we rewrite these so that these keys are always set:

configuration['browser'] = TestUtils.isBrowserRuntime(runtime);

If we do that we should be able to avoid null checks later.

https://codereview.chromium.org/11028023/diff/2001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11028023/diff/2001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1447: return
'third_party/firefox_jsshell/${configuration['system']}';
You should make this relative to dartDir which will point to the top of the dart
repo.

https://codereview.chromium.org/11028023/diff/2001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1458: if (configuration['system'] == 'linux')
{
Do you only need to add something for linux? Does both mac and win search the
current directory for shared libraries?

[ricow1, 2012-10-04 12:02:05]

https://codereview.chromium.org/11028023/diff/2001/tools/testing/dart/test_op...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/11028023/diff/2001/tools/testing/dart/test_op...
tools/testing/dart/test_options.dart:479: configuration['browser'] = true;
On 2012/10/04 11:33:35, Mads Ager wrote:
> Can we rewrite these so that these keys are always set:
> 
> configuration['browser'] = TestUtils.isBrowserRuntime(runtime);
> 
> If we do that we should be able to avoid null checks later.

Done.

https://codereview.chromium.org/11028023/diff/2001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11028023/diff/2001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1447: return
'third_party/firefox_jsshell/${configuration['system']}';
On 2012/10/04 11:33:35, Mads Ager wrote:
> You should make this relative to dartDir which will point to the top of the
dart
> repo.
We don't do this for d8 or for dart2js, but done

https://codereview.chromium.org/11028023/diff/2001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1458: if (configuration['system'] == 'linux')
{
On 2012/10/04 11:33:35, Mads Ager wrote:
> Do you only need to add something for linux? Does both mac and win search the
> current directory for shared libraries?
On windows this worked and as discussed offline this also works on mac

[ahe, 2012-10-04 13:12:26]

LGTM!

https://codereview.chromium.org/11028023/diff/2001/tools/testing/dart/test_op...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/11028023/diff/2001/tools/testing/dart/test_op...
tools/testing/dart/test_options.dart:482: if
(TestUtils.isCommandLineRuntime(runtime)) {
isJsCommandLineRuntime?

https://codereview.chromium.org/11028023/diff/2001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11028023/diff/2001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1475: static bool isCommandLineRuntime(String
runtime) =>
isJsCommandLineRuntime?

[ricow1, 2012-10-04 13:19:41]

Patch to patch diff slightly messed up due to rebase

https://codereview.chromium.org/11028023/diff/2001/tools/testing/dart/test_op...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/11028023/diff/2001/tools/testing/dart/test_op...
tools/testing/dart/test_options.dart:482: if
(TestUtils.isCommandLineRuntime(runtime)) {
On 2012/10/04 13:12:26, ahe wrote:
> isJsCommandLineRuntime?

Yes, that is better, thx

https://codereview.chromium.org/11028023/diff/2001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11028023/diff/2001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1475: static bool isCommandLineRuntime(String
runtime) =>
On 2012/10/04 13:12:26, ahe wrote:
> isJsCommandLineRuntime?

Done.

[Mads Ager (google), 2012-10-04 14:51:24]

LGTM