Issue 11028018: Missed a change in the rename from initCustomEvent -> $dom_initCustomEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11028018: Missed a change in the rename from initCustomEvent -> $dom_initCustomEvent. (Closed)

Created:
8 years, 2 months ago by Emily Fortuna

Modified:
8 years, 2 months ago

Reviewers:
vsm, blois

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Missed a change in the rename from initCustomEvent -> $dom_initCustomEvent. Committed: https://code.google.com/p/dart/source/detail?r=13134

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -12 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View		3 chunks	+17 lines, -3 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		4 chunks	+17 lines, -3 lines	0 comments	Download
M	lib/html/scripts/htmlrenamer.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/html/src/Isolates.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	lib/html/src/shared_FactoryProviders.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	lib/html/templates/html/interface/interface_CustomEvent.darttemplate	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	tests/html/event_customevent_test.dart	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

This is identical to the previous CL, but I forgot to add the file lib/html/src/Isolates.dart ...

8 years, 2 months ago (2012-10-02 18:01:53 UTC) #1

blois

lgtm https://codereview.chromium.org/11028018/diff/5001/lib/html/src/Isolates.dart File lib/html/src/Isolates.dart (right): https://codereview.chromium.org/11028018/diff/5001/lib/html/src/Isolates.dart#newcode197 lib/html/src/Isolates.dart:197: event.$dom_initCustomEvent(receiver, false, false, JSON.stringify(message)); Can this not use ...

8 years, 2 months ago (2012-10-02 19:59:00 UTC) #2