Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 11027059: Add apply method signature to Function class. (Closed)

Created:
8 years, 2 months ago by Lasse Reichstein Nielsen
Modified:
8 years, 2 months ago
Reviewers:
ngeoffray, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add apply method signature to Function class. This does not include an implementation for any backend. The current implementation throws a NotImplementedException when called. BUG=5419 Committed: https://code.google.com/p/dart/source/detail?r=13292

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -1 line) Patch
M lib/compiler/implementation/lib/core_patch.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M lib/core/function.dart View 1 1 chunk +25 lines, -0 lines 0 comments Download
A runtime/lib/function_patch.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/lib/lib_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A tests/corelib/apply_test.dart View 1 chunk +79 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Lasse Reichstein Nielsen
8 years, 2 months ago (2012-10-05 11:59:03 UTC) #1
kasperl
LGTM. Maybe Nicolas should take a look too? https://codereview.chromium.org/11027059/diff/1/lib/core/function.dart File lib/core/function.dart (right): https://codereview.chromium.org/11027059/diff/1/lib/core/function.dart#newcode27 lib/core/function.dart:27: * ...
8 years, 2 months ago (2012-10-05 12:51:54 UTC) #2
Lasse Reichstein Nielsen
https://codereview.chromium.org/11027059/diff/1/lib/core/function.dart File lib/core/function.dart (right): https://codereview.chromium.org/11027059/diff/1/lib/core/function.dart#newcode27 lib/core/function.dart:27: * if [positionalArguments] is null, it's considered an empty ...
8 years, 2 months ago (2012-10-05 12:52:58 UTC) #3
ngeoffray
LGTM https://codereview.chromium.org/11027059/diff/1/tests/corelib/apply_test.dart File tests/corelib/apply_test.dart (right): https://codereview.chromium.org/11027059/diff/1/tests/corelib/apply_test.dart#newcode38 tests/corelib/apply_test.dart:38: testMap(res, func, map) { Looks better with named ...
8 years, 2 months ago (2012-10-05 12:57:29 UTC) #4
Lasse Reichstein Nielsen
8 years, 2 months ago (2012-10-08 07:52:01 UTC) #5
https://codereview.chromium.org/11027059/diff/1/tests/corelib/apply_test.dart
File tests/corelib/apply_test.dart (right):

https://codereview.chromium.org/11027059/diff/1/tests/corelib/apply_test.dart...
tests/corelib/apply_test.dart:38: testMap(res, func, map) {
The content of the functions differ, so having a single function with two
optional parameters would just turn it into one function with three distinct
bodies and some switching logic. That's usually a sign that it should be
separate functions.

Powered by Google App Engine
This is Rietveld 408576698