Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11027033: Move Dart type narrowing to TypeRegistry. (Closed)

Created:
8 years, 2 months ago by podivilov
Modified:
8 years, 2 months ago
Reviewers:
Anton Muhin, podivilov1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move Dart type narrowing to TypeRegistry. R=antonm@google.com Committed: https://code.google.com/p/dart/source/detail?r=13248

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -18 lines) Patch
M lib/html/scripts/generator.py View 1 2 6 chunks +28 lines, -2 lines 0 comments Download
M lib/html/scripts/systemhtml.py View 1 2 1 chunk +1 line, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
podivilov
8 years, 2 months ago (2012-10-04 17:28:13 UTC) #1
Anton Muhin
https://codereview.chromium.org/11027033/diff/1/lib/html/scripts/generator.py File lib/html/scripts/generator.py (right): https://codereview.chromium.org/11027033/diff/1/lib/html/scripts/generator.py#newcode719 lib/html/scripts/generator.py:719: def narrow_dart_type(self): why this override?
8 years, 2 months ago (2012-10-04 17:30:07 UTC) #2
podivilov1
https://codereview.chromium.org/11027033/diff/1/lib/html/scripts/generator.py File lib/html/scripts/generator.py (right): https://codereview.chromium.org/11027033/diff/1/lib/html/scripts/generator.py#newcode719 lib/html/scripts/generator.py:719: def narrow_dart_type(self): On 2012/10/04 17:30:07, Anton Muhin wrote: > ...
8 years, 2 months ago (2012-10-04 17:46:54 UTC) #3
Anton Muhin
8 years, 2 months ago (2012-10-04 17:48:08 UTC) #4 
Now diff looks like a sum of several CLs, please, be careful when submitting.

LGTM

Powered by Google App Engine
This is Rietveld 408576698