Dart analyzer fixes to improve pluggability.

Dart analyzer fixes to improve pluggability.

More fixes in the service of supporting analysis of resources that are non-resident.  Notably a pluggable UrlLibrarySource and a repurposable SystemLibrariesReader.

NOTE (API Change): SystemLibraryProvider is now an abstract class, suitable for client customization. 
Committed: https://code.google.com/p/dart/source/detail?r=13084

[Brian Wilkerson, 2012-10-01 19:49:53]

LGTM, other than one minor nit

http://codereview.chromium.org/11027006/diff/1/compiler/java/com/google/dart/...
File compiler/java/com/google/dart/compiler/SystemLibrariesReader.java (right):

http://codereview.chromium.org/11027006/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/SystemLibrariesReader.java:188:
loadLibraryInfo();
Could we just pass the sdkFileReader into loadLibraryInfo rather than storing it
in an instance field?

[keertip, 2012-10-01 19:55:46]

lgtm

[pquitslund, 2012-10-01 20:15:13]

http://codereview.chromium.org/11027006/diff/1/compiler/java/com/google/dart/...
File compiler/java/com/google/dart/compiler/SystemLibrariesReader.java (right):

http://codereview.chromium.org/11027006/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/SystemLibrariesReader.java:188:
loadLibraryInfo();
On 2012/10/01 19:49:53, Brian Wilkerson wrote:
> Could we just pass the sdkFileReader into loadLibraryInfo rather than storing
it
> in an instance field?

Sure thing!  Done.