Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1102613002: Analyzer CLI removal. (Closed)

Created:
5 years, 8 months ago by pquitslund
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Analyzer CLI removal. CLI now lives in dedicated `analyzer_cli` package. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=45362

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1519 lines) Patch
M pkg/analyzer/CHANGELOG.md View 1 2 1 chunk +10 lines, -0 lines 2 comments Download
D pkg/analyzer/bin/analyzer.dart View 1 chunk +0 lines, -151 lines 0 comments Download
D pkg/analyzer/lib/options.dart View 1 1 chunk +0 lines, -443 lines 0 comments Download
D pkg/analyzer/lib/src/analyzer_impl.dart View 1 chunk +0 lines, -498 lines 0 comments Download
D pkg/analyzer/lib/src/error_formatter.dart View 1 chunk +0 lines, -201 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 1 chunk +0 lines, -1 line 0 comments Download
D pkg/analyzer/test/error_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D pkg/analyzer/test/options_test.dart View 1 chunk +0 lines, -168 lines 0 comments Download
M pkg/analyzer/test/test_all.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/pkg.status View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/pkg_tested/pkg_tested.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
pquitslund
5 years, 8 months ago (2015-04-22 17:18:50 UTC) #2
kevmoo
How does this change the pubspec.yaml? Can we remove args? Anything else?
5 years, 8 months ago (2015-04-22 17:26:29 UTC) #4
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-04-22 17:26:35 UTC) #5
pquitslund
On 2015/04/22 17:26:29, kevmoo wrote: > How does this change the pubspec.yaml? > > Can ...
5 years, 8 months ago (2015-04-22 17:56:50 UTC) #6
pquitslund
Committed patchset #3 (id:40001) manually as r45362 (presubmit successful).
5 years, 8 months ago (2015-04-22 20:32:18 UTC) #7
kevmoo
On 2015/04/22 20:32:18, pquitslund wrote: > Committed patchset #3 (id:40001) manually as r45362 (presubmit successful). ...
5 years, 8 months ago (2015-04-22 20:48:05 UTC) #8
nweiz
5 years, 8 months ago (2015-04-23 19:44:03 UTC) #10
Message was sent while issue was closed.
DBC

https://codereview.chromium.org/1102613002/diff/40001/pkg/analyzer/CHANGELOG.md
File pkg/analyzer/CHANGELOG.md (right):

https://codereview.chromium.org/1102613002/diff/40001/pkg/analyzer/CHANGELOG....
pkg/analyzer/CHANGELOG.md:4: ** `bin/analyzer.dart`
This "**" syntax isn't valid markdown and doesn't format well. See
https://pub.dartlang.org/packages/analyzer#changelog.

https://codereview.chromium.org/1102613002/diff/40001/pkg/analyzer/CHANGELOG....
pkg/analyzer/CHANGELOG.md:5: ** `lib/analyzer.dart`
AFAICT this file is still in the package, which is good since many non-CLI
clients rely on it.

Powered by Google App Engine
This is Rietveld 408576698