Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1255)

Issue 11026039: Refactor idl to dart renaming logic for interfaces. (Closed)

Created:
8 years, 2 months ago by podivilov
Modified:
8 years, 2 months ago
Reviewers:
Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Refactor idl to dart renaming logic for interfaces. Make sure all types that comes to TypeRegistry.TypeInfo are either registered or present in database. That is to fix the mess with idl vs. dart types. Also, InterfaceIDLTypeInfo.dart_type now returns an already renamed type. R=antonm@google.com Committed: https://code.google.com/p/dart/source/detail?r=13247

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -34 lines) Patch
M lib/html/idl/dart/dart.idl View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/scripts/dartgenerator.py View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/scripts/generator.py View 1 8 chunks +41 lines, -22 lines 0 comments Download
M lib/html/scripts/systemhtml.py View 1 7 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
podivilov
8 years, 2 months ago (2012-10-04 16:32:37 UTC) #1
Anton Muhin
https://codereview.chromium.org/11026039/diff/1/lib/html/scripts/generator.py File lib/html/scripts/generator.py (right): https://codereview.chromium.org/11026039/diff/1/lib/html/scripts/generator.py#newcode349 lib/html/scripts/generator.py:349: if param.dart_type == 'Dynamic': nit cannot rename_type handle the ...
8 years, 2 months ago (2012-10-04 16:41:04 UTC) #2
podivilov
http://codereview.chromium.org/11026039/diff/1/lib/html/scripts/generator.py File lib/html/scripts/generator.py (right): http://codereview.chromium.org/11026039/diff/1/lib/html/scripts/generator.py#newcode349 lib/html/scripts/generator.py:349: if param.dart_type == 'Dynamic': On 2012/10/04 16:41:04, Anton Muhin ...
8 years, 2 months ago (2012-10-04 17:44:10 UTC) #3
Anton Muhin
8 years, 2 months ago (2012-10-04 17:45:19 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698