Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 11026035: Fix Hello World size regression. (Closed)

Created:
8 years, 2 months ago by ahe
Modified:
8 years, 2 months ago
Reviewers:
karlklose, ngeoffray
CC:
reviews_dartlang.org, bakster
Visibility:
Public.

Description

Fix Hello World size regression. Committed: https://code.google.com/p/dart/source/detail?r=13218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M dart/lib/compiler/implementation/lib/js_helper.dart View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ahe
8 years, 2 months ago (2012-10-04 11:02:40 UTC) #1
ahe
Before: info: compiled 247594 bytes Dart -> 29495 bytes JavaScript in out.js After: info: compiled ...
8 years, 2 months ago (2012-10-04 11:03:42 UTC) #2
karlklose
LGTM.
8 years, 2 months ago (2012-10-04 11:06:32 UTC) #3
ngeoffray
LGTM, thanks for paying attention Peter.
8 years, 2 months ago (2012-10-04 11:07:16 UTC) #4
ahe
8 years, 2 months ago (2012-10-04 11:07:28 UTC) #5
These are the numbers from compiling this this program:

main() { print('Hello, World!'); }

Using:

dart2js -v hello_world.dart

On 2012/10/04 11:03:42, ahe wrote:
> Before:
> 
> info: compiled 247594 bytes Dart -> 29495 bytes JavaScript in out.js
> 
> After:
> 
> info: compiled 247781 bytes Dart -> 2400 bytes JavaScript in out.js

Powered by Google App Engine
This is Rietveld 408576698