Issue 11026011: Add isolate event handler setup in order to be able to propagate isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11026011: Add isolate event handler setup in order to be able to propagate isolate (Closed)

Created:
8 years, 2 months ago by siva

Modified:
8 years, 2 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org, keertip, devoncarew

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Add isolate event handler setup in order to be able to propagate isolate events (create/shutdown/interrupted) Committed: https://code.google.com/p/dart/source/detail?r=13130

Patch Set 5 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -46 lines)			Patch
M	bin/dbg_connection.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	bin/dbg_connection.cc	View	1 2 3 4	2 chunks	+16 lines, -0 lines	0 comments	Download
M	bin/main.cc	View	1 2 3 4	2 chunks	+6 lines, -6 lines	0 comments	Download
M	include/dart_debugger_api.h	View	1 2 3 4	2 chunks	+16 lines, -0 lines	0 comments	Download
M	vm/code_generator.cc	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download
M	vm/debugger.h	View	1 2 3 4	7 chunks	+11 lines, -5 lines	0 comments	Download
M	vm/debugger.cc	View	1 2 3 4	5 chunks	+36 lines, -25 lines	0 comments	Download
M	vm/debugger_api_impl.cc	View	1 2 3 4	3 chunks	+17 lines, -10 lines	0 comments	Download
M	vm/isolate.cc	View	1 2 3 4	3 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

lgtm https://chromiumcodereview.appspot.com/11026011/diff/12/vm/debugger.h File vm/debugger.h (right): https://chromiumcodereview.appspot.com/11026011/diff/12/vm/debugger.h#newcode276 vm/debugger.h:276: static void SignalIsolateEvent(EventType type); Maybe group this with ...

8 years, 2 months ago (2012-10-02 17:45:55 UTC) #2

siva

8 years, 2 months ago (2012-10-02 18:09:31 UTC) #3

https://chromiumcodereview.appspot.com/11026011/diff/12/vm/debugger.h
File vm/debugger.h (right):

https://chromiumcodereview.appspot.com/11026011/diff/12/vm/debugger.h#newcode276
vm/debugger.h:276: static void SignalIsolateEvent(EventType type);
On 2012/10/02 17:45:55, hausner wrote:
> Maybe group this with the other SignalXXX functions below?

Done.

Expand Messages | Collapse Messages

Issue 11026011: Add isolate event handler setup in order to be able to propagate isolate (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Messages