Do not put renaming logic into Unparser.

Do not put renaming logic into Unparser.

Move it into EmitterUnparser instead to separate both clearly.

R=ahe@google.com,smok@google.com

Committed: https://code.google.com/p/dart/source/detail?r=13121

[Roman, 2012-10-02 07:55:55]

lgtm

It's almost the same

https://codereview.chromium.org/11026006/diff/1/lib/compiler/implementation/d...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://codereview.chromium.org/11026006/diff/1/lib/compiler/implementation/d...
lib/compiler/implementation/dart_backend/backend.dart:467: // TODO(smok): Remove
ugly hack for library prefices.
prefixes ?

[Anton Muhin, 2012-10-02 08:48:42]

https://codereview.chromium.org/11026006/diff/1/lib/compiler/implementation/d...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://codereview.chromium.org/11026006/diff/1/lib/compiler/implementation/d...
lib/compiler/implementation/dart_backend/backend.dart:467: // TODO(smok): Remove
ugly hack for library prefices.
O tempora, o mores!

Let's wait for Peter's opinion.

On 2012/10/02 07:55:55, Roman wrote:
> prefixes ?

[ahe, 2012-10-02 14:27:39]

LGTM!

https://codereview.chromium.org/11026006/diff/1/lib/compiler/implementation/d...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://codereview.chromium.org/11026006/diff/1/lib/compiler/implementation/d...
lib/compiler/implementation/dart_backend/backend.dart:468: if (node.receiver !==
null && renames[node.receiver] == '') return;
I'm not sure what problem this is solving. If you show me an example, perhaps I
have a suggestion for getting rid of it.

[Anton Muhin, 2012-10-02 14:32:15]

https://codereview.chromium.org/11026006/diff/1/lib/compiler/implementation/d...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://codereview.chromium.org/11026006/diff/1/lib/compiler/implementation/d...
lib/compiler/implementation/dart_backend/backend.dart:468: if (node.receiver !==
null && renames[node.receiver] == '') return;
That'd be great, Peter.

The problem.  Imagine you use name with a prefix.  When we bundle the
application in a single file in most of the cases we want to delete this prefix
and emit the name w/o the prefix and that's the best way we came up by to
achieve that.

If notion of the name would have its own Send node, that is prefix.value = 1
would have translated into SendSet { target: Send { receiver: prefix, selector:
value }, value = 1 }, we could have renamed it at the level of nodes.

I'll submit this CL in ~20 mins after I ran the test.

On 2012/10/02 14:27:39, ahe wrote:
> I'm not sure what problem this is solving. If you show me an example, perhaps
I
> have a suggestion for getting rid of it.

[ahe, 2012-10-09 07:40:59]

https://codereview.chromium.org/11026006/diff/1/lib/compiler/implementation/d...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://codereview.chromium.org/11026006/diff/1/lib/compiler/implementation/d...
lib/compiler/implementation/dart_backend/backend.dart:468: if (node.receiver !==
null && renames[node.receiver] == '') return;
Anton, could you give me an example with actual code?

On 2012/10/02 14:32:15, Anton Muhin wrote:
> That'd be great, Peter.
> 
> The problem.  Imagine you use name with a prefix.  When we bundle the
> application in a single file in most of the cases we want to delete this
prefix
> and emit the name w/o the prefix and that's the best way we came up by to
> achieve that.
> 
> If notion of the name would have its own Send node, that is prefix.value = 1
> would have translated into SendSet { target: Send { receiver: prefix,
selector:
> value }, value = 1 }, we could have renamed it at the level of nodes.
> 
> I'll submit this CL in ~20 mins after I ran the test.
> 
> On 2012/10/02 14:27:39, ahe wrote:
> > I'm not sure what problem this is solving. If you show me an example,
perhaps
> I
> > have a suggestion for getting rid of it.
>

[Anton Muhin, 2012-10-10 07:21:40]

https://codereview.chromium.org/11026006/diff/1/lib/compiler/implementation/d...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://codereview.chromium.org/11026006/diff/1/lib/compiler/implementation/d...
lib/compiler/implementation/dart_backend/backend.dart:468: if (node.receiver !==
null && renames[node.receiver] == '') return;
I assume you're asking for code being transformed.  If not, I'll show how we do
it.

Imagine the code

import 'mylib.dart' as mylib;

main() {
  mylib.topLevelField = 13;
}

where mylib.dart is

int topLevelField = 42;

we'd like to emit (omitting renames):

topLevelField = 42;

main() {
  topLevelField = 13;
}

omitting the prefix.

Our whole renamer can rename the whole AST nodes---we have a map from a node to
string where most of those nodes are identifiers and sometimes it sends, Roma is
currently unifying it all.

However, in this case this would be a send set and there is no node to rename
to, so we need this special trick to mark AST node as one that should be
actually removed the input.

Does that make sense?

Is there simpler approach?

We're considering AST rewrites for those, fyi.


On 2012/10/09 07:40:59, ahe wrote:
> Anton, could you give me an example with actual code?
> 
> On 2012/10/02 14:32:15, Anton Muhin wrote:
> > That'd be great, Peter.
> > 
> > The problem.  Imagine you use name with a prefix.  When we bundle the
> > application in a single file in most of the cases we want to delete this
> prefix
> > and emit the name w/o the prefix and that's the best way we came up by to
> > achieve that.
> > 
> > If notion of the name would have its own Send node, that is prefix.value = 1
> > would have translated into SendSet { target: Send { receiver: prefix,
> selector:
> > value }, value = 1 }, we could have renamed it at the level of nodes.
> > 
> > I'll submit this CL in ~20 mins after I ran the test.
> > 
> > On 2012/10/02 14:27:39, ahe wrote:
> > > I'm not sure what problem this is solving. If you show me an example,
> perhaps
> > I
> > > have a suggestion for getting rid of it.
> > 
>