Issue 11024003: Add a fixed array type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11024003: Add a fixed array type. (Closed)

Created:
8 years, 2 months ago by ngeoffray

Modified:
8 years, 2 months ago

Reviewers:
Søren Gjesse, floitsch

CC:
reviews_dartlang.org, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add a fixed array type. Committed: https://code.google.com/p/dart/source/detail?r=13224

Patch Set 4 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -12 lines)			Patch
M	lib/compiler/implementation/ssa/nodes.dart	View	1	2 chunks	+6 lines, -5 lines	0 comments	Download
M	lib/compiler/implementation/ssa/optimize.dart	View	1	2 chunks	+17 lines, -7 lines	0 comments	Download
M	lib/compiler/implementation/ssa/types.dart	View	1	4 chunks	+31 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/type_combination_test.dart	View	1	43 chunks	+89 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm http://codereview.chromium.org/11024003/diff/4001/lib/compiler/implementation/ssa/types.dart File lib/compiler/implementation/ssa/types.dart (right): http://codereview.chromium.org/11024003/diff/4001/lib/compiler/implementation/ssa/types.dart#newcode615 lib/compiler/implementation/ssa/types.dart:615: const HFixedArrayType(); Would it make sense to add ...

8 years, 2 months ago (2012-10-01 06:47:31 UTC) #2

ngeoffray

8 years, 2 months ago (2012-10-01 21:54:39 UTC) #3

Thanks Soren

http://codereview.chromium.org/11024003/diff/4001/lib/compiler/implementation...
File lib/compiler/implementation/ssa/types.dart (right):

http://codereview.chromium.org/11024003/diff/4001/lib/compiler/implementation...
lib/compiler/implementation/ssa/types.dart:615: const HFixedArrayType();
On 2012/10/01 06:47:31, Søren Gjesse wrote:
> Would it make sense to add the length (if known) to the HFixedArrayType?

Yes, I was planning on doing that as the next step.

Expand Messages | Collapse Messages

Issue 11024003: Add a fixed array type. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages