Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 110233002: Reapply "Reduce footprint of HTML Timer by not creating a "cancel" closure." (Closed)

Created:
7 years ago by Lasse Reichstein Nielsen
Modified:
7 years ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert and reapply "Reduce footprint of HTML Timer by not creating a "cancel" closure." Committed: https://code.google.com/p/dart/source/detail?r=30986 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=31013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -34 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +14 lines, -17 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 chunk +14 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
Experimentally reverting. If it doesn't fix buildbot redness, I'll recommit. TBR.
7 years ago (2013-12-09 13:12:51 UTC) #1
Lasse Reichstein Nielsen
Committed patchset #1 manually as r30986 (presubmit successful).
7 years ago (2013-12-09 13:13:16 UTC) #2
floitsch
LGTM.
7 years ago (2013-12-09 13:39:33 UTC) #3
Lasse Reichstein Nielsen
7 years ago (2013-12-10 10:36:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r31013 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698