Issue 11020008: Cleanup html events generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11020008: Cleanup html events generation. (Closed)

Created:
8 years, 2 months ago by podivilov

Modified:
8 years, 2 months ago

Reviewers:
Anton Muhin, podivilov1, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cleanup html events generation. Get rid of HtmlSystemShared and move event interfaces and implementations generation to HtmlEventGenerator class. R=antonm@google.com,sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=13107

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+288 lines, -312 lines)			Patch
M	lib/html/scripts/dartdomgenerator.py	View	2 chunks	+4 lines, -3 lines	0 comments	Download
A	lib/html/scripts/htmleventgenerator.py	View	1 chunk	+266 lines, -0 lines	2 comments	Download
M	lib/html/scripts/systemhtml.py	View	8 chunks	+16 lines, -307 lines	0 comments	Download
M	lib/html/scripts/systemnative.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm https://codereview.chromium.org/11020008/diff/1/lib/html/scripts/htmleventgenerator.py File lib/html/scripts/htmleventgenerator.py (right): https://codereview.chromium.org/11020008/diff/1/lib/html/scripts/htmleventgenerator.py#newcode9 lib/html/scripts/htmleventgenerator.py:9: # We can automatically extract most event event ...

8 years, 2 months ago (2012-10-01 14:38:38 UTC) #2

podivilov1

8 years, 2 months ago (2012-10-02 12:09:15 UTC) #3

https://codereview.chromium.org/11020008/diff/1/lib/html/scripts/htmleventgen...
File lib/html/scripts/htmleventgenerator.py (right):

https://codereview.chromium.org/11020008/diff/1/lib/html/scripts/htmleventgen...
lib/html/scripts/htmleventgenerator.py:9: # We can automatically extract most
event event names by checking for
On 2012/10/01 14:38:38, Anton Muhin wrote:
> nit: duplicate 'event event'

Done.

Expand Messages | Collapse Messages