Issue 11019011: Cleaning up in VM number hierarchy which was exposing a bunch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11019011: Cleaning up in VM number hierarchy which was exposing a bunch (Closed)

Created:
8 years, 2 months ago by Mads Ager (google)

Modified:
8 years, 2 months ago

Reviewers:
Søren Gjesse, Lasse Reichstein Nielsen, srdjan

CC:
reviews_dartlang.org, srdjan, Ivan Posva

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cleaning up in VM number hierarchy which was exposing a bunch of implementation details as public methods. The only remaining thing is that int and double have a pow method in the VM which is not officially a part of corelib. Maybe it should be so I have left that out of this change and maybe we should add it to num and implement in dart2js too? R=sgjesse@google.com,lrn@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=13066

Patch Set 1 #

Patch Set 2 : Remove formatting changes #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -103 lines)			Patch
M	runtime/lib/double.dart	View	1	3 chunks	+28 lines, -29 lines	0 comments	Download
M	runtime/lib/integers.dart	View		6 chunks	+31 lines, -31 lines	0 comments	Download
M	runtime/vm/intrinsifier.h	View		2 chunks	+11 lines, -10 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View		1 chunk	+0 lines, -14 lines	1 comment	Download
M	runtime/vm/intrinsifier_x64.cc	View		1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

8 years, 2 months ago (2012-10-01 16:16:35 UTC) #3

http://codereview.chromium.org/11019011/diff/2001/runtime/vm/intrinsifier_ia3...
File runtime/vm/intrinsifier_ia32.cc (left):

http://codereview.chromium.org/11019011/diff/2001/runtime/vm/intrinsifier_ia3...
runtime/vm/intrinsifier_ia32.cc:737: }
Why eliminate negate intrinsification? I will restore it (the method is called
VM internally "unary-".

Expand Messages | Collapse Messages