Issue 11017069: - Remove deprecated Dart API calls Dart_ClosureSmrck and DartClosureSetSmrck

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11017069: - Remove deprecated Dart API calls Dart_ClosureSmrck and DartClosureSetSmrck (Closed)

Created:
8 years, 2 months ago by siva

Modified:
8 years, 2 months ago

Reviewers:
Anton Muhin, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

- Remove deprecated Dart API calls Dart_ClosureSmrck and DartClosureSetSmrck - Remove the smrck field from RawClosure object. Committed: https://code.google.com/p/dart/source/detail?r=13559

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -40 lines)			Patch
M	include/dart_api.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	vm/dart_api_impl.cc	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	vm/object.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	vm/raw_object.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	vm/stub_code_ia32.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	vm/stub_code_x64.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Anton Muhin

8 years, 2 months ago (2012-10-11 13:45:40 UTC) #3

lgtm and you should be good to go---I've submitted the change to switch to peer
API