Issue 11017064: Add missing scope initializations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11017064: Add missing scope initializations. (Closed)

Created:
8 years, 2 months ago by cshapiro

Modified:
8 years, 2 months ago

Reviewers:
Anton Muhin, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	runtime/vm/dart_api_impl.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

siva

LGTM. We should also add a test case UNIT_TEST_CASE(GetSetPeer) { void* out = &out; EXPECT(Dart_IsError(Dart_GetPeer(Dart_Null(), ...

8 years, 2 months ago (2012-10-10 21:33:16 UTC) #2

cshapiro

I will add this test and re-upload. Shouldn't all of the API functions have such ...

8 years, 2 months ago (2012-10-10 21:38:10 UTC) #3

cshapiro

Per offline discussions, we will delay adding a unit test until we can clearly validate ...

8 years, 2 months ago (2012-10-10 23:36:02 UTC) #4

Anton Muhin

8 years, 2 months ago (2012-10-11 05:55:58 UTC) #5

lgtm and thanks, I'll proceed with switching Dartium to peer API