Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 11017052: Test of AbstractClassInstantiationError. (Closed)

Created:
8 years, 2 months ago by ahe
Modified:
8 years, 2 months ago
Reviewers:
bakster, gbracha, kasperl
CC:
reviews_dartlang.org, aam-me
Visibility:
Public.

Description

Test of AbstractClassInstantiationError. Committed: https://code.google.com/p/dart/source/detail?r=13517

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Kasper's review comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
A dart/tests/language/abstract_runtime_error_test.dart View 1 1 chunk +43 lines, -0 lines 1 comment Download
M dart/tests/language/language_dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ahe
Gilad, Kasper, and Lars: please confirm this is what is agreed upon.
8 years, 2 months ago (2012-10-10 08:33:28 UTC) #1
kasperl
LGTM. This matches what I expect. https://codereview.chromium.org/11017052/diff/1/dart/tests/language/abstract_runtime_error_test.dart File dart/tests/language/abstract_runtime_error_test.dart (right): https://codereview.chromium.org/11017052/diff/1/dart/tests/language/abstract_runtime_error_test.dart#newcode29 dart/tests/language/abstract_runtime_error_test.dart:29: try { Maybe ...
8 years, 2 months ago (2012-10-10 08:43:49 UTC) #2
ahe
Thank you, Kasper https://codereview.chromium.org/11017052/diff/1/dart/tests/language/abstract_runtime_error_test.dart File dart/tests/language/abstract_runtime_error_test.dart (right): https://codereview.chromium.org/11017052/diff/1/dart/tests/language/abstract_runtime_error_test.dart#newcode29 dart/tests/language/abstract_runtime_error_test.dart:29: try { On 2012/10/10 08:43:49, kasperl ...
8 years, 2 months ago (2012-10-10 09:27:20 UTC) #3
bakster
LGTM, Lars https://codereview.chromium.org/11017052/diff/3001/dart/tests/language/abstract_runtime_error_test.dart File dart/tests/language/abstract_runtime_error_test.dart (right): https://codereview.chromium.org/11017052/diff/3001/dart/tests/language/abstract_runtime_error_test.dart#newcode41 dart/tests/language/abstract_runtime_error_test.dart:41: Expect.stringEquals('ConcreteSubclass', '${new ConcreteSubclass()}'); I prefer: Expect.equals(new ConcreteSubclass() ...
8 years, 2 months ago (2012-10-10 13:56:17 UTC) #4
gbracha
8 years, 2 months ago (2012-10-10 17:30:08 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698