Remove slow assert from VM.

Remove slow assert from VM.

Replaced slow-asserts with verify-compiler and removed vm/assert.h

R=srdjan@google.com
BUG=5720
Committed: https://code.google.com/p/dart/source/detail?r=13456

[srdjan, 2012-10-09 16:28:51]

LGTM with comments and thanks!

http://codereview.chromium.org/11017027/diff/1/runtime/vm/flow_graph.cc
File runtime/vm/flow_graph.cc (right):

http://codereview.chromium.org/11017027/diff/1/runtime/vm/flow_graph.cc#newco...
runtime/vm/flow_graph.cc:129: (1 == MembershipCount(use,
use->definition()->input_use_list())));
Would it make sense to do verification in release mode as well (if flag is set)?

http://codereview.chromium.org/11017027/diff/1/runtime/vm/flow_graph.cc#newco...
runtime/vm/flow_graph.cc:200: DEBUG_ASSERT(!FLAG_verify_compiler ||
Why DEBUG_ASSERT instead of ASSERT? All identifiers are defined in release mode
as well, aren't they? (Also for some of changes below).

[zerny-google, 2012-10-10 07:44:54]

http://codereview.chromium.org/11017027/diff/1/runtime/vm/flow_graph.cc
File runtime/vm/flow_graph.cc (right):

http://codereview.chromium.org/11017027/diff/1/runtime/vm/flow_graph.cc#newco...
runtime/vm/flow_graph.cc:129: (1 == MembershipCount(use,
use->definition()->input_use_list())));
On 2012/10/09 16:28:52, srdjan wrote:
> Would it make sense to do verification in release mode as well (if flag is
set)?

We could, but currently all of the verification code is wrapped in an #ifdef
DEBUG condition. Since verification is really is for development debugging I
think this is a reasonable thing to do.

http://codereview.chromium.org/11017027/diff/1/runtime/vm/flow_graph.cc#newco...
runtime/vm/flow_graph.cc:200: DEBUG_ASSERT(!FLAG_verify_compiler ||
On 2012/10/09 16:28:52, srdjan wrote:
> Why DEBUG_ASSERT instead of ASSERT? All identifiers are defined in release
mode
> as well, aren't they? (Also for some of changes below).

No, the verification code (including MembershipCount) is only inclued in debug
mode.