Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Issue 11017017: Fix bug with missing unboxed mint-to-double conversion. (Closed)

Created:
8 years, 2 months ago by Florian Schneider
Modified:
8 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bug with missing unboxed mint-to-double conversion. In case of a mixed integer/double operation that has a mint input, the corresponding conversion from unboxed mint to unboxed double was missing. This CL converts a unboxed mint to a double by first boxing, and then unboxing. Currently, we deoptimize in case the result does not fit into a smi because we can only optimize mixed smi/double operations and not yet mint/double operations. BUG=dart:5721 TEST=tests/language/mint_arithmetic.dart Committed: http://code.google.com/p/dart/source/detail?r=13372

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -16 lines) Patch
M runtime/vm/flow_graph_optimizer.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 2 chunks +24 lines, -16 lines 0 comments Download
M tests/language/mint_arithmetic.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
8 years, 2 months ago (2012-10-08 19:01:57 UTC) #1
srdjan
LGTM https://codereview.chromium.org/11017017/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/11017017/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode145 runtime/vm/flow_graph_optimizer.cc:145: CreateConversion(from_rep, to_rep, instr, use, def, deopt_target); Maybe rename ...
8 years, 2 months ago (2012-10-08 19:36:15 UTC) #2
Florian Schneider
8 years, 2 months ago (2012-10-08 20:18:56 UTC) #3
https://codereview.chromium.org/11017017/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/11017017/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:145: CreateConversion(from_rep, to_rep,
instr, use, def, deopt_target);
On 2012/10/08 19:36:15, srdjan wrote:
> Maybe rename CreateConversion to InsertConversion?

Done.

Powered by Google App Engine
This is Rietveld 408576698