Issue 11017006: Create and use new change/depends flags for the GVN analysis.

Issue 11017006: Create and use new change/depends flags for the GVN analysis. (Closed)

Created:
8 years, 2 months ago by ngeoffray

Modified:
8 years, 2 months ago

Reviewers:
Søren Gjesse, floitsch, kasperl

CC:
reviews_dartlang.org, floitsch

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Create and use new change/depends flags for the GVN analysis. Committed: https://code.google.com/p/dart/source/detail?r=13220

Patch Set 3 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -46 lines)			Patch
M	lib/compiler/implementation/ssa/builder.dart	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/ssa/nodes.dart	View	1 2	20 chunks	+95 lines, -40 lines	0 comments	Download
M	lib/compiler/implementation/world.dart	View	1	2 chunks	+19 lines, -4 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

LGTM! http://codereview.chromium.org/11017006/diff/2001/lib/compiler/implementation/ssa/nodes.dart File lib/compiler/implementation/ssa/nodes.dart (right): http://codereview.chromium.org/11017006/diff/2001/lib/compiler/implementation/ssa/nodes.dart#newcode762 lib/compiler/implementation/ssa/nodes.dart:762: static const int FLAG_CHANGES_STATIC = FLAG_CHANGES_PROPERTY + 1; ...

8 years, 2 months ago (2012-10-01 07:22:20 UTC) #2

floitsch

DBC. http://codereview.chromium.org/11017006/diff/2001/lib/compiler/implementation/ssa/nodes.dart File lib/compiler/implementation/ssa/nodes.dart (right): http://codereview.chromium.org/11017006/diff/2001/lib/compiler/implementation/ssa/nodes.dart#newcode1474 lib/compiler/implementation/ssa/nodes.dart:1474: // Getter interceptors do not have side effects. ...

8 years, 2 months ago (2012-10-01 08:40:30 UTC) #3

ngeoffray

http://codereview.chromium.org/11017006/diff/2001/lib/compiler/implementation/ssa/nodes.dart File lib/compiler/implementation/ssa/nodes.dart (right): http://codereview.chromium.org/11017006/diff/2001/lib/compiler/implementation/ssa/nodes.dart#newcode1474 lib/compiler/implementation/ssa/nodes.dart:1474: // Getter interceptors do not have side effects. On ...

8 years, 2 months ago (2012-10-01 21:56:10 UTC) #4

ngeoffray

Thanks Soren and Florian. http://codereview.chromium.org/11017006/diff/2001/lib/compiler/implementation/ssa/nodes.dart File lib/compiler/implementation/ssa/nodes.dart (right): http://codereview.chromium.org/11017006/diff/2001/lib/compiler/implementation/ssa/nodes.dart#newcode762 lib/compiler/implementation/ssa/nodes.dart:762: static const int FLAG_CHANGES_STATIC = ...

8 years, 2 months ago (2012-10-04 10:41:42 UTC) #5

ngeoffray

8 years, 2 months ago (2012-10-04 11:59:26 UTC) #6

The optimization revealed a bug in how we handle try/finally (see issue 5643),
so I marked the test exercising the bug as fail for now.

Expand Messages | Collapse Messages